This fix does not fix the package corruption. Should get it fixed later today.

This fix does not fix the package corruption. Should get it fixed later today.

This PR only fix syntax error if $dep_status != 'met'
For array_search func, the 2nd param must be array, current is NULL

        var_dump($dep_hash);
        var_dump($dep_status);
        var_dump($ignorable_type_code_hashes);
        if ($dep_status == 'met') {
            $dep_status_text = "<span class='foundDependency'>" . __('Found Dependency:') . '</span>';
        } else if (array_search($ignorable_type_code_hashes, $dep_hash) === false) {
            $dep_status_text = "<span class='unmetDependency'>" . __('Unmet Dependency:') . '</span>';
            $dep_errors = true;
        }

string(43) "hash_0101037fc923d81fd11083628731e271c3fa6a"
string(3) "met"
NULL

The $needle is what we are searching for (aka $dep_hash). The $ingorable_type_code_hashes are the $haystack.

array_search($needle, $haystack);

@TheWitness is correct @ddb4github. The function should have the needle first: https://www.php.net/manual/en/function.array-search.php

However, I have just re-committed the correct array_search call as it was wrong in the code still. There is also the removal of a check that the ignorable's variable exists. That check created an empty array which may not be desirable either so I've flagged that on the commit and @TheWitness and I will likely have to discuss how that could happen if at all.

@TheWitness is correct @ddb4github. The function should have the needle first: https://www.php.net/manual/en/function.array-search.php

Yes, #4695 (comment) just show previous code line before you re-commit.

BTW, as your said (#4695 (comment)), $ingorable_type_code_hashes might be empty when the first array_search