When running under PHP 5.4, certain operators are not valid#4688
Merged
TheWitness merged 3 commits intoCacti:1.2.xfrom Apr 9, 2022
Merged
When running under PHP 5.4, certain operators are not valid#4688TheWitness merged 3 commits intoCacti:1.2.xfrom
TheWitness merged 3 commits intoCacti:1.2.xfrom
Conversation
Member
|
Release has already been made. It'll be a 1.2.21 fix. |
Member
|
@ddb4github, please add a ChangeLog update too thanks. |
TheWitness
reviewed
Apr 9, 2022
Member
TheWitness
left a comment
There was a problem hiding this comment.
Did you remove #4284 on accident?
Member
|
I returned it. |
Contributor
Author
No, 4284 is duplicated in 1.2.18 section, |
TheWitness
added a commit
that referenced
this pull request
Jul 20, 2022
TheWitness
added a commit
that referenced
this pull request
Jul 20, 2022
This reverts commit b58327e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Readme, Cacti 1.2.x support PHP 5.4+, so replace PHP 7.0 operator
??with?:Related to #4475 and #4662
These two errors are introduced after 1.2.19. CHANGELOG might be not required if @netniV recreate release/1.2.20 tag