Create an empty centroids in Hazard.concat() with CRS from the first haz_list. #881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Very well! Can you add tests and changelog? |
emanuel-schmid
requested changes
May 13, 2024
climada/hazard/base.py
Outdated
Comment on lines
819
to
821
| haz_concat = haz_list[0].__class__() | ||
| haz_concat.haz_type = haz_list[0].haz_type | ||
| haz_concat.centroids = Centroids(lat=[], lon=[], crs=haz_list[0].centroids.crs) |
Collaborator
There was a problem hiding this comment.
Exactly! 😄
Alternatively one may inject the centroids as an argument of haz_list[0].__class__. (And possibly skip the haz_type assignment. I suspect that it is already assigned at that point through the constructor)
peanutfun
requested changes
May 31, 2024
Member
peanutfun
left a comment
There was a problem hiding this comment.
@manniepmkam, as discussed in person, please
- fix the linter issue: Line too long
- add a unit test that covers the case reported in #879 (comment)
Collaborator
Author
I have updated the line.
The unit test for hazard.base has been updated accordingly. Please review that. |
peanutfun
requested changes
Jun 18, 2024
Member
peanutfun
left a comment
There was a problem hiding this comment.
Looks good, but you should check for the exact error message and not just any ValueError, see my comment.
peanutfun
approved these changes
Jun 18, 2024
Member
|
@manniepmkam Thanks a lot for the bugfix! 🙌 |
gdeskos
pushed a commit
to gdeskos/climada_python
that referenced
this pull request
Sep 16, 2024
…rd (CLIMADA-project#881) * add test for Hazard.concat for failing crs * Update error message for Centroids.append
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
This pull request is a fix for issue #879.
An empty centroids is created in the
Hazard.concat()function with the crs from the haz object from the haz_list.This PR fixes #
PR Author Checklist
develop)PR Reviewer Checklist