Bugfix lon_bounds returning range > 360 degrees #859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Tests are failing: it looks like these tests also failed in last night's Jenkins build so I'm hoping this is unrelated. |
tovogt
approved these changes
Mar 14, 2024
Collaborator
tovogt
left a comment
There was a problem hiding this comment.
Well spotted, thanks for the fix!
gdeskos
pushed a commit
to gdeskos/climada_python
that referenced
this pull request
Sep 16, 2024
* Bugfix coordinates.lon_bounds for edge case returning >360 range See issue CLIMADA-project#858 * lon_bounds: refactor --------- Co-authored-by: Thomas Vogt <thomas.vogt@pik-potsdam.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #858
PR Author Checklist
develop)PR Reviewer Checklist