adapt to changed worldbank data #841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peanutfun
requested changes
Jan 18, 2024
Member
peanutfun
left a comment
There was a problem hiding this comment.
Thanks for updating the test! Could you maybe change the variable names in the test as indicated? Also, please add a Changelog entry. Then, we are ready to merge.
climada/util/test/test_finance.py
Outdated
| """Test Processed Capital value Cuba 2015 (missing value).""" | ||
| ref_year = 2015 | ||
| cntry_iso = 'CUB' | ||
| res_year, res_val, q = world_bank_wealth_account(cntry_iso, ref_year, no_land=1) |
Member
There was a problem hiding this comment.
The variable names res_ and ref_ are really hard to distinguish. Could you maybe change the res_ to wb_?
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
This PR fixes #835
PR Author Checklist
develop)PR Reviewer Checklist