Feature/init trop cyclone #567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I think we should wait for the Hazard base class to be ready before continuing here. |
Member
|
I agree! |
# Conflicts: # climada/hazard/trop_cyclone.py Conflicts resolved manually. In particular the radius arguments in Holland methods is given in 'km' (default value and doc-string)
Collaborator
|
I think this is ready to be merged. 🎉 |
Collaborator
|
🥳 |
simonameiler
pushed a commit
that referenced
this pull request
Aug 24, 2023
* add type hints * trop_cyclone: order imports * trop_cyclone: remove trailing whitespaces * trop_cyclone: np.array -> np.ndarray * trop_cyclone: pass kwargs to Hazard base class * TropCyclone: more type hinting Co-authored-by: Thomas Vogt <thomas.vogt@pik-potsdam.de> Co-authored-by: emanuel-schmid <schmide@ethz.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
PR Author Checklist
develop)PR Reviewer Checklist