Fix issues with new containers for arrangement cells#6094
Merged
lrineau merged 6 commits intoCGAL:5.3.x-branchfrom Nov 18, 2021
Merged
Fix issues with new containers for arrangement cells#6094lrineau merged 6 commits intoCGAL:5.3.x-branchfrom
lrineau merged 6 commits intoCGAL:5.3.x-branchfrom
Conversation
use Compact_container::clear() that will deallocate by blocks and clear the freelist
lrineau
reviewed
Nov 4, 2021
Comment on lines
+346
to
+349
| iterator begin() { return empty()?iterator(last_item, 0):iterator(first_item, 0, 0); } | ||
| iterator end() { return iterator(last_item, 0); } | ||
|
|
||
| const_iterator begin() const { return const_iterator(first_item, 0, 0); } | ||
| const_iterator begin() const { return empty()?const_iterator(last_item, 0):const_iterator(first_item, 0, 0); } |
Member
There was a problem hiding this comment.
Should be applied to the Concurrent_compact_container as well.
the freelist being not clear is actually an issue when small arrangement are created out of large one
Member
Author
|
We basically undo changes of #5408 |
Member
Author
|
Successfully tested in CGAL-5.4-Ic-95 |
lrineau
added a commit
that referenced
this pull request
Nov 18, 2021
Fix issues with new containers for arrangement cells # Conflicts: # Arrangement_on_surface_2/include/CGAL/Arr_dcel_base.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6092