Skip to content

Remove cpp11::(tuple|get)#4774

Merged
lrineau merged 5 commits intoCGAL:masterfrom
lrineau:CGAL-remove_cpp11-GF
Jun 23, 2020
Merged

Remove cpp11::(tuple|get)#4774
lrineau merged 5 commits intoCGAL:masterfrom
lrineau:CGAL-remove_cpp11-GF

Conversation

@lrineau
Copy link
Copy Markdown
Member

@lrineau lrineau commented Jun 9, 2020 •
edited
Loading

Summary of Changes

Remove cpp11. And use #ifdef CGAL_NO_DEPRECATED_CODE around the backward
compatibility code in <CGAL/config.h>.

See also: #4775 (same PR for CGAL-5.0.x)

Release Management

  • Affected package(s): CMap, Spatial_searching, Surface_mesh_topology

@lrineau lrineau added this to the 5.1-beta2 milestone Jun 9, 2020
@sloriot sloriot mentioned this pull request Jun 9, 2020
Closed
79 tasks
@sloriot
Copy link
Copy Markdown
Member

sloriot commented Jun 9, 2020

Note that you could even have applied it to the 5.0 branch but it is not that important. (Anyway it might have been introduced with the Surface_mesh_topology package).

lrineau added 3 commits June 9, 2020 20:11
@lrineau
Remove cpp11::(tuple|get)
ec1dd74 
And use `#ifdef CGAL_NO_DEPRECATED_CODE` around the backward
compatibility code in `<CGAL/config.h>`.
@lrineau
Merge remote-tracking branch 'cgal/master' into CGAL-remove_cpp11-GF
52b83a9
@lrineau
Remove cpp11::(tuple|get)
e6536aa 
And use `#ifdef CGAL_NO_DEPRECATED_CODE` around the backward
compatibility code in `<CGAL/config.h>`.
@lrineau lrineau force-pushed the CGAL-remove_cpp11-GF branch from 1549d9a to e6536aa Compare June 9, 2020 18:24
@lrineau lrineau mentioned this pull request Jun 9, 2020
Merged
@lrineau
Copy link
Copy Markdown
Member Author

lrineau commented Jun 9, 2020

Note that you could even have applied it to the 5.0 branch but it is not that important. (Anyway it might have been introduced with the Surface_mesh_topology package).

Done in #4775, and I have modified the history of this PR to merge the other one.

@lrineau
Copy link
Copy Markdown
Member Author

lrineau commented Jun 10, 2020

@maxGimeno You should test #4775 instead of this one (#4774).

@maxGimeno
Copy link
Copy Markdown
Contributor

maxGimeno commented Jun 11, 2020

Oops, yes indeed

@lrineau
Copy link
Copy Markdown
Member Author

lrineau commented Jun 11, 2020

@maxGimeno You should test #4775 instead of this one (#4774).

Actually, I wrote it the wrong way: we should test this one (#4774) instead of #4775.

@maxGimeno
Copy link
Copy Markdown
Contributor

maxGimeno commented Jun 11, 2020

Oh

@maxGimeno
Copy link
Copy Markdown
Contributor

maxGimeno commented Jun 12, 2020

Errors: https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-5.1-Ic-174/Advancing_front_surface_reconstruction_Examples/TestReport_lrineau_Ubuntu-Latest-NO_DEPRECATED_CODE.gz

@lrineau
Copy link
Copy Markdown
Member Author

lrineau commented Jun 12, 2020

Fixed in 8205112.

@maxGimeno
Copy link
Copy Markdown
Contributor

maxGimeno commented Jun 15, 2020

cgal/Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/internal/Smoothing/curvature_flow_impl.h

Line 37 in 8205112

#include <vector>

A #include<unordered_map> is missing around here(according to https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-5.1-Ic-175/Polygon_mesh_processing/TestReport_lrineau_Ubuntu-Latest-NO_DEPRECATED_CODE.gz)

@maxGimeno
Copy link
Copy Markdown
Contributor

maxGimeno commented Jun 23, 2020

Successfully tested in https://cgal.geometryfactory.com/CGAL/testsuite/results-5.1-Ic-182.shtml

@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Jun 23, 2020
@lrineau lrineau merged commit dad9db1 into CGAL:master Jun 23, 2020
@lrineau lrineau deleted the CGAL-remove_cpp11-GF branch June 23, 2020 17:01
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Jun 23, 2020
@lrineau lrineau mentioned this pull request Sep 10, 2020
Closed
89 tasks
@lrineau lrineau mentioned this pull request Jun 2, 2021
Closed
70 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@maxGimeno maxGimeno

Labels

Bug Master Version of Release Branch PR Merged_in_5.1 Modern C++ (C++11 and later) tested manually on Linux Tested

Projects

None yet

Milestone

5.1-beta2

Development

Successfully merging this pull request may close these issues.

3 participants

@lrineau @sloriot @maxGimeno