Skip to content

Tetrahedral remeshing - new package#4620

Merged
lrineau merged 259 commits intoCGAL:masterfrom
janetournois:Tetrahedral_remeshing-new-jtournois
Jun 3, 2020
Merged

Tetrahedral remeshing - new package#4620
lrineau merged 259 commits intoCGAL:masterfrom
janetournois:Tetrahedral_remeshing-new-jtournois

Conversation

@janetournois
Copy link
Copy Markdown
Member

@janetournois janetournois commented Apr 6, 2020

Summary of Changes

This PR introduces a new package for Tetrahedral Remeshing.
It implements Noura Faraj, Jean-Marc Thiery and Tamy Boubekeur's article : Multi-Material Adaptive Volume Remesher

Warning : I am creating this PR to start testing the code, but the user manual is still uncomplete, and there is one bug remaining in the code. So it's ready to start testing, but not to be merged.

Release Management

  • Affected package(s): New Package
  • Feature/Small Feature (if any): feature accepted
  • Link to compiled documentation : Reference Manual
  • License and copyright ownership: GPL / GeometryFactory and Telecom Paris

TODO:

  • @sloriot Filter the branch (wrong license)

TODO (after merge):

  • News entry

and do not use Tr&
using Mesh_triangulation_3 (which is an enriched Regular_triangulation_3)
compiles, but the calls of tr.is_valid() fail since the triangulation
is not regular anymore after remeshing

we reconvert it back to the demo c3t3 triangulation type anyhow, to be able
to display it, hoping that is_valid() will not be called later on
Corner_index and Curve_segment_index are int by default in C3t3
and move all dump_***() functions to the same file
because there are more than one representation of the same Edge,
all around it
the goal is to let a visitor deal with external cell info
it also simplifies the API
@sloriot
Copy link
Copy Markdown
Member

sloriot commented May 27, 2020

@lrineau I implemented in the last commit the solution you do not like to resolve the license dependency issue with Mesh_3. Since there are 17 files modified it is not a so bad solution for now. In 5.2 we should create a new 3D mesh DS package containing those files (+ move some in the IO package).

@lrineau
Copy link
Copy Markdown
Member

lrineau commented May 27, 2020

@maxGimeno Is there anything in the testsuite preventing the merge of this PR?

@sloriot
Copy link
Copy Markdown
Member

sloriot commented May 27, 2020

I'm still working on a few things with Jane and Mael

@sloriot
Copy link
Copy Markdown
Member

sloriot commented May 27, 2020

Will merge it in integration when done if OK for you.

@lrineau
Copy link
Copy Markdown
Member

lrineau commented May 27, 2020

Yes, that's OK for me. Thanks.

@sloriot sloriot force-pushed the Tetrahedral_remeshing-new-jtournois branch from 3eba266 to 25b0dc5 Compare May 27, 2020 17:21
@sloriot
Copy link
Copy Markdown
Member

sloriot commented May 28, 2020

Tests look good for this one now. Note that the commit I did this morning is just adding an empty line to have a title properly aligned (I tested locally that it fixes the issue).

@maxGimeno
Copy link
Copy Markdown
Contributor

@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Jun 3, 2020
@lrineau lrineau merged commit a828cb0 into CGAL:master Jun 3, 2020
@lrineau lrineau deleted the Tetrahedral_remeshing-new-jtournois branch June 3, 2020 14:32
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Jun 3, 2020
@lrineau
Copy link
Copy Markdown
Member

lrineau commented Jun 3, 2020

TODO:

lrineau added a commit that referenced this pull request Jun 10, 2020
@lrineau lrineau mentioned this pull request Jul 2, 2020
1 task
@MaelRL MaelRL removed the TODO (web) label Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants