Skip to content

CGAL 3D Demo: Enhancement of the Scene Saving System#4212

Merged
sloriot merged 18 commits intoCGAL:masterfrom
maxGimeno:Demo-Save_the_scene_entirely-maxGimeno
Mar 16, 2020
Merged

CGAL 3D Demo: Enhancement of the Scene Saving System#4212
sloriot merged 18 commits intoCGAL:masterfrom
maxGimeno:Demo-Save_the_scene_entirely-maxGimeno

Conversation

@maxGimeno
Copy link
Copy Markdown
Contributor

@maxGimeno maxGimeno commented Sep 9, 2019

Summary of Changes

Saves the whole scene into the .js file. It means it is whole items that are stored in the .js, not only paths to existing files.
The items content are stored as base64 binary data, so it doesn't matter the file format (ascii or binary or both) used.

Release Management

@maxGimeno maxGimeno force-pushed the Demo-Save_the_scene_entirely-maxGimeno branch 11 times, most recently from 070d761 to d79570f Compare September 17, 2019 09:12
@maxGimeno maxGimeno marked this pull request as ready for review September 26, 2019 12:48
@maxGimeno maxGimeno added this to the 5.0-beta2 milestone Sep 26, 2019
@maxGimeno maxGimeno force-pushed the Demo-Save_the_scene_entirely-maxGimeno branch from fa73b8e to af5773c Compare September 26, 2019 13:04
@maxGimeno maxGimeno modified the milestones: 5.0-beta2, 5.1-beta Sep 30, 2019
@maxGimeno maxGimeno force-pushed the Demo-Save_the_scene_entirely-maxGimeno branch from aa2e3ff to 6701a73 Compare October 4, 2019 07:26
@maxGimeno
Copy link
Copy Markdown
Contributor Author

@lrineau @sloriot We need to discuss this and find a solution at some point

@lrineau
Copy link
Copy Markdown
Member

lrineau commented Feb 17, 2020

@lrineau @sloriot We need to discuss this and find a solution at some point

Then please list the services/ports the demo will start listening to, after this PR, and then we can start the discussion.

@maxGimeno
Copy link
Copy Markdown
Contributor Author

@lrineau @sloriot We need to discuss this and find a solution at some point

Then please list the services/ports the demo will start listening to, after this PR, and then we can start the discussion.

SSH on port 22 and WebSockets are the new protocols used. For the websocket, the user specifies the whole adress for the server to be used, including the port.

@sloriot sloriot changed the base branch from master to releases/CGAL-4.14-branch February 20, 2020 10:06
@sloriot sloriot changed the base branch from releases/CGAL-4.14-branch to master February 20, 2020 10:06
@@ -0,0 +1,247 @@
#ifdef CGAL_USE_SSH
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxGimeno Most of that file is probably a copy-paste from somewhere. We should check on which license we can put this file.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you remember the source of the copy-paste?

Copy link
Copy Markdown
Contributor Author

@maxGimeno maxGimeno Feb 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is all based on the guide provided by libssh : https://api.libssh.org/stable/libssh_tutor_scp.html#scp_subsystem

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The put the file under the license LGPLv3+.

@CGAL CGAL deleted a comment from sloriot Feb 20, 2020
@maxGimeno
Copy link
Copy Markdown
Contributor Author

@sloriot sloriot merged commit 0c8e9cb into CGAL:master Mar 16, 2020
@sloriot sloriot deleted the Demo-Save_the_scene_entirely-maxGimeno branch March 16, 2020 15:35
@sloriot sloriot self-assigned this Mar 16, 2020
@maxGimeno maxGimeno mentioned this pull request Mar 17, 2020
66 tasks
MaelRL added a commit to maxGimeno/cgal that referenced this pull request Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve sharing of a demo setting

4 participants