Implementation of linkage algorithm against new schema#52
Merged
Conversation
alhayward
reviewed
Sep 30, 2024
cbrinson-rise8
approved these changes
Oct 1, 2024
1 task
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the big one, this is a reimplementation of the linkage algorithm using the new schema. The new algorithm has been added to
recordlinker.linking.link.Related Issues
closes #23
Additional Notes
FEATUREliteral type with aFeatureenum for better type safety and readability. (src/recordlinker/models/pii.py)src/recordlinker/linkage/matchers.pyandsrc/recordlinker/linking/matchers.py)FEATURE_COMPARE_FUNCandMATCH_RULE_FUNCto use floats instead of booleans for more granular matching. (src/recordlinker/linking/matchers.py)src/recordlinker/models/mpi.py)<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process:
This pull request includes significant changes to the
recordlinkermodule to improve feature matching and update the codebase to use more descriptive and consistent identifiers. The most important changes involve modifying the feature comparison functions to return float values instead of booleans, updating theFeaturemodel to use an enum, and adjusting related unit tests.