Skip to content

Reorganizing models#36

Merged
ericbuckley merged 51 commits into
mainfrom
feature/23-reorg-models
Sep 26, 2024
Merged

Reorganizing models#36
ericbuckley merged 51 commits into
mainfrom
feature/23-reorg-models

Conversation

@ericbuckley

@ericbuckley ericbuckley commented Sep 24, 2024

Copy link
Copy Markdown
Collaborator

Description

Reorganizing models into the recordlinker.models package.

Related Issues

Related to issue #23

Additional Notes

  • Reorganizing the models into 4 separate modules to keep their purposes distinct.
    • recordlinker.models.base: general high purpose base implementations for the ORM
    • recordlinker.models.mpi: models specific to the MPI tables
    • recordlinker.models.algorithm: models specific to persisting the algorithm configuration
    • recordlinker.models.pii: models specific to parsing patient document input
  • Moving recordlinker.linkage.simple_mpi to recordlinker.linking.mpi_service. Going forward, the recordlinker.linkage package will be the old schema/algorithm and the recordlinker.linking package will be the new one.
  • Adding two new matchers, simple_feature_match_exact and simple_feature_match_fuzzy_string, for processing structured record and Patient data (for future use by the upcoming recordlinker.linking.link module)

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.
  • I have notified teammates in the review thread to build awareness.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@ericbuckley ericbuckley self-assigned this Sep 24, 2024
@ericbuckley ericbuckley added the api New API feature label Sep 24, 2024
@ericbuckley ericbuckley linked an issue Sep 24, 2024 that may be closed by this pull request
3 tasks
@ericbuckley ericbuckley marked this pull request as ready for review September 24, 2024 22:37
Comment thread src/recordlinker/linkage/matchers.py Outdated
Comment thread src/recordlinker/linkage/matchers.py Outdated
Comment thread src/recordlinker/models/pii.py
Comment thread alembic/versions/0c90faa0378f_create_algorithm_tables.py
Comment thread alembic/versions/591a56cee781_.py
Comment thread alembic/versions/f5716ac94693_dropping_mpi_schema.py
Comment thread src/recordlinker/models/base.py
@ericbuckley ericbuckley merged commit e1a1a69 into main Sep 26, 2024
@ericbuckley ericbuckley deleted the feature/23-reorg-models branch September 26, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api New API feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

simple_link module

2 participants