Skip to content

upgrade tj-actions/changed-files#256

Merged
ericbuckley merged 4 commits into
mainfrom
fix/tj-action-vulnerability
Mar 19, 2025
Merged

upgrade tj-actions/changed-files#256
ericbuckley merged 4 commits into
mainfrom
fix/tj-action-vulnerability

Conversation

@ericbuckley

@ericbuckley ericbuckley commented Mar 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Removing tj-actions, it's not necessary for our mypy check, as it's ok to type check all the code. This specifically addresses CVE-2025-30066

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@ericbuckley ericbuckley added the dependencies Pull requests that update a dependency file label Mar 19, 2025
@ericbuckley ericbuckley self-assigned this Mar 19, 2025
@ericbuckley ericbuckley marked this pull request as ready for review March 19, 2025 15:52
@codecov

codecov Bot commented Mar 19, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.80%. Comparing base (3caa109) to head (8cfab25).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #256   +/-   ##
=======================================
  Coverage   97.80%   97.80%           
=======================================
  Files          33       33           
  Lines        1731     1731           
=======================================
  Hits         1693     1693           
  Misses         38       38

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

m-goggins
m-goggins approved these changes Mar 19, 2025
View reviewed changes

@m-goggins m-goggins left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ericbuckley ericbuckley merged commit f6cc2d2 into main Mar 19, 2025
@ericbuckley ericbuckley deleted the fix/tj-action-vulnerability branch March 19, 2025 16:23
bamader pushed a commit that referenced this pull request Mar 19, 2025
@ericbuckley @bamader
upgrade tj-actions/changed-files (#256)
9d105c7 
## Description
Removing tj-actions, it's not necessary for our mypy check, as it's ok
to type check all the code. This specifically addresses
[CVE-2025-30066](https://www.cve.org/CVERecord?id=CVE-2025-30066)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m-goggins m-goggins m-goggins approved these changes

@bamader bamader Awaiting requested review from bamader bamader is a code owner

Assignees

@ericbuckley ericbuckley

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ericbuckley @m-goggins