Skip to content

Add ER diagram title and description#241

Merged
ericbuckley merged 1 commit into
mainfrom
a11y/er-diagram-title
Mar 10, 2025
Merged

Add ER diagram title and description#241
ericbuckley merged 1 commit into
mainfrom
a11y/er-diagram-title

Conversation

@ericbuckley

@ericbuckley ericbuckley commented Mar 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Adding a title and description to the ER diagram in site/design.md to improve accessibility.

https://mermaid.js.org/config/accessibility.html#accessible-title-and-description

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@ericbuckley ericbuckley added the a11y Making digital accessibility easier label Mar 10, 2025
@ericbuckley ericbuckley self-assigned this Mar 10, 2025
@ericbuckley ericbuckley marked this pull request as ready for review March 10, 2025 17:44
@codecov

codecov Bot commented Mar 10, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.75%. Comparing base (f41e4af) to head (70e7a03).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #241   +/-   ##
=======================================
  Coverage   97.75%   97.75%           
=======================================
  Files          32       32           
  Lines        1689     1689           
=======================================
  Hits         1651     1651           
  Misses         38       38

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ericbuckley ericbuckley merged commit 35b38bb into main Mar 10, 2025
@ericbuckley ericbuckley deleted the a11y/er-diagram-title branch March 10, 2025 19:04
bamader pushed a commit that referenced this pull request Mar 19, 2025
@ericbuckley @bamader
Add ER diagram title and description (#241)
1b84ebd 
## Description
Adding a title and description to the ER diagram in site/design.md to
improve accessibility.

https://mermaid.js.org/config/accessibility.html#accessible-title-and-description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m-goggins m-goggins m-goggins approved these changes

@bamader bamader Awaiting requested review from bamader bamader is a code owner

Assignees

@ericbuckley ericbuckley

Labels

a11y Making digital accessibility easier

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ericbuckley @m-goggins