Removed first 2 chars of authority from IDENTIFIER blocking key#227
Merged
Conversation
BREAKING CHANGE: The format of IDENTIFIER blocking keys has changed, and databases should be reset before upgrading.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #227 +/- ##
=======================================
Coverage 97.69% 97.70%
=======================================
Files 32 32
Lines 1651 1653 +2
=======================================
+ Hits 1613 1615 +2
Misses 38 38 ☔ View full report in Codecov by Sentry. |
bamader
approved these changes
Feb 27, 2025
bamader
left a comment
Collaborator
There was a problem hiding this comment.
Nice and easy, a good fix
bamader
pushed a commit
that referenced
this pull request
Mar 19, 2025
## Description
Changing IDENTIFIER blocking keys to `{value[-4:]}:{type}` format,
authority is no longer present in the keys.
BREAKING CHANGE: The format of IDENTIFIER blocking keys has changed, and
databases should be reset before upgrading.
## Related Issues
closes #226
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changing IDENTIFIER blocking keys to
{value[-4:]}:{type}format, authority is no longer present in the keys.BREAKING CHANGE: The format of IDENTIFIER blocking keys has changed, and databases should be reset before upgrading.
Related Issues
closes #226
<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: