Reverse identifiers for comparisons#211
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
=======================================
Coverage 97.65% 97.65%
=======================================
Files 32 32
Lines 1576 1576
=======================================
Hits 1539 1539
Misses 37 37 ☔ View full report in Codecov by Sentry. |
ericbuckley
reviewed
Feb 10, 2025
ericbuckley
reviewed
Feb 10, 2025
ericbuckley
previously approved these changes
Feb 10, 2025
ericbuckley
approved these changes
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since Jaro-Winkler is the default similarity measure for string comparisons, more weight is given to differences at the start of a string. As such, this PR modifies the way that we yield and store Identifiers for comparison. Previously, the Identifier format was
type:authority:valuebut now it isvalue:authority:typeto give more weight to the value. For example, when comparing two MRNs with values,1234and2345, we will now give more weight to1234vs2345than the type, e.g.,MRvsMR. This should yield better differentiation between strings.Related Issues
Fixes #200
Additional Notes
I updated the language in the RFC to reflect the new format and added a note at the bottom to indicate that the RFC has been changed.