Add BlockingKey descriptions to openapi.json#188
Merged
Conversation
m-goggins
previously approved these changes
Feb 3, 2025
m-goggins
left a comment
Collaborator
There was a problem hiding this comment.
The overall code looks good to me, just added a few questions to clarify my own understanding.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #188 +/- ##
==========================================
+ Coverage 97.51% 97.65% +0.14%
==========================================
Files 31 32 +1
Lines 1486 1576 +90
==========================================
+ Hits 1449 1539 +90
Misses 37 37 ☔ View full report in Codecov by Sentry. |
m-goggins
previously approved these changes
Feb 6, 2025
Co-authored-by: Marcelle <53578688+m-goggins@users.noreply.github.com>
m-goggins
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small updates to the existing BlockingKey descriptions and changing the schema to include the description as well as the value when rendering the information in
GET /openapi.jsonRelated Issues
closes #187
<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: