Skip to content

Add cleaning step to process skip_values #233

@ericbuckley

Description

@ericbuckley

Summary

Implement a new cleaning step to copy PIIRecords with skip_values removed as per RFC-003.

Acceptance Criteria

  • A new cleaning method for PIIRecords that can copy an existing object, parse some skip rules and return a new one.
  • Apply cleaning method to both incoming payloads and selected patients from blocking results
  • Test cases

Details / Tasks

Consider implementing this new method somewhere in the "recordlinker/linking" module as to avoid a circular dependency between schema definitions. Also take care to invoke the cleaning step on both the incoming payload and found patient records in the MPI as early as possible, so we don't call the cleaning operation more than what's needed.

The Patient class in models/mpi.py as some tricky circular dependencies defined on the record property. This maybe be a good opportunity to refactor those circular dependencies, if so, feel free to tackle that work here.

Dependencies

#232. Largely this work isn't dependant, however the work from #232 will likely create some new schema object from which a list of skip value definitions are defined. This work is necessary for the cleaning method, as it will need to know how to process that schema.

Related Issues/PRs

#215

Metadata

Metadata

Assignees

Labels

apiNew API feature

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions