RFC-003: skip values#218
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
=======================================
Coverage 97.80% 97.80%
=======================================
Files 33 33
Lines 1731 1731
=======================================
Hits 1693 1693
Misses 38 38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
m-goggins
reviewed
Feb 18, 2025
m-goggins
previously approved these changes
Feb 24, 2025
bamader
previously approved these changes
Feb 24, 2025
bamader
left a comment
Collaborator
There was a problem hiding this comment.
I like the approach generally but wanted to flag a possible concern around using NAME rather than jointly considering First and Last. Nothing that's blocker level, but just raising.
bamader
approved these changes
Feb 27, 2025
bamader
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, I think we're there with this!
This was referenced Feb 28, 2025
Collaborator
Author
|
Moving this to ON HOLD for the time being. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A proposal to introduce system changes allowing users to define skip conditions for placeholder values to be ignored during the linkage process.
Related Issues
closes #215
<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: