Skip to content

Fixes processing of definition lists#97

Closed
alyjak wants to merge 2 commits intoByron:mainfrom
alyjak:definition_list
Closed

Fixes processing of definition lists#97
alyjak wants to merge 2 commits intoByron:mainfrom
alyjak:definition_list

Conversation

@alyjak
Copy link
Contributor

@alyjak alyjak commented Feb 10, 2025

Without this fix in place, definition lists do not capture block contents, only the first element in the definition entry.

Copy link
Owner

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, great work!

I have rewritten the commit subjects to produce better changelog entries, but besides that left everything unchanged.

Due to the rewrite, GitHub won't recognise the PR is merged and I have to close it.

The new release is here: https://github.com/Byron/pulldown-cmark-to-cmark/releases/tag/v20.0.1 .

@Byron
Copy link
Owner

Byron commented Feb 12, 2025

Closed as it was merged with rewritten commits.

@Byron Byron closed this Feb 12, 2025
@alyjak alyjak deleted the definition_list branch February 12, 2025 10:34
danieleades pushed a commit to danieleades/pulldown-cmark-to-cmark that referenced this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants