Fix error due to output buffer not finalized correctly#1724
Merged
kevinthfang merged 2 commits intorelease/0.4.xfrom Jun 21, 2024
Merged
Fix error due to output buffer not finalized correctly#1724kevinthfang merged 2 commits intorelease/0.4.xfrom
kevinthfang merged 2 commits intorelease/0.4.xfrom
Conversation
When http requests come with 'compressed=1', HTTPHandler uses CompressedWriteBuffer. But it missed to call its finalize() explicitly. Then finalize() is invoked in the dctor, which happens after the response is sent. As a result, the response has incomplete data.
kevinthfang
approved these changes
Jun 21, 2024
nudles
added a commit
that referenced
this pull request
Aug 26, 2024
Fix error due to output buffer not finalized correctly
nudles
added a commit
that referenced
this pull request
Aug 26, 2024
Fix error due to output buffer not finalized correctly
nudles
added a commit
that referenced
this pull request
Aug 30, 2024
Merge pull request #1724 from ByConity/fix-http-compress-1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When http requests come with 'compressed=1', HTTPHandler uses CompressedWriteBuffer. But it missed to call its finalize() explicitly. Then finalize() is invoked in the dctor, which happens after the response is sent. As a result, the response has incomplete data.
This commit fixes it by calling the finalize() method explicitly.
fix #1698
refer to ClickHouse/ClickHouse#58846