Ensure that trivial skipping is done prior to filesystem calls.#1660
Closed
rkhoury wants to merge 2 commits intoBurntSushi:masterfrom
Closed
Ensure that trivial skipping is done prior to filesystem calls.#1660rkhoury wants to merge 2 commits intoBurntSushi:masterfrom
rkhoury wants to merge 2 commits intoBurntSushi:masterfrom
Conversation
This seems like an obvious optimization but becomes critical when filesystem operations even as simple as stat can result in significant overheads; an example of this was a bespoke filesystem layer in Windows that hosted files remotely and would download them on-demand when particular filesystem operations occurred. Users of this system who ensured correct file-type fileters were being used could still get unnecessary file access resulting in large downloads.
Contributor
Author
|
This is based on the discussion: #1657 |
BurntSushi
pushed a commit
that referenced
this pull request
May 31, 2021
This seems like an obvious optimization but becomes critical when filesystem operations even as simple as stat can result in significant overheads; an example of this was a bespoke filesystem layer in Windows that hosted files remotely and would download them on-demand when particular filesystem operations occurred. Users of this system who ensured correct file-type fileters were being used could still get unnecessary file access resulting in large downloads. Fixes #1657, Closes #1660
BurntSushi
pushed a commit
that referenced
this pull request
Jun 1, 2021
This seems like an obvious optimization but becomes critical when filesystem operations even as simple as stat can result in significant overheads; an example of this was a bespoke filesystem layer in Windows that hosted files remotely and would download them on-demand when particular filesystem operations occurred. Users of this system who ensured correct file-type fileters were being used could still get unnecessary file access resulting in large downloads. Fixes #1657, Closes #1660
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems like an obvious optimization but becomes critical when
filesystem operations even as simple as stat can result in
significant overheads; an example of this was a bespoke filesystem
layer in Windows that hosted files remotely and would download them
on-demand when particular filesystem operations occurred. Users of
this system who ensured correct file-type fileters were being used
could still get unnecessary file access resulting in large downloads.