On Windows MSVC, statically link the C runtime#1613
Closed
AustinWise wants to merge 1 commit intoBurntSushi:masterfrom
AustinWise:austin/StaticlyLinkMsvcrt
Closed
On Windows MSVC, statically link the C runtime#1613AustinWise wants to merge 1 commit intoBurntSushi:masterfrom AustinWise:austin/StaticlyLinkMsvcrt
AustinWise wants to merge 1 commit intoBurntSushi:masterfrom
AustinWise:austin/StaticlyLinkMsvcrt
Conversation
Before this change, rg.exe depended on vcruntime140.dll, which does not exist on a fresh install of Windows.
Contributor
Author
|
There is precedence for using this option. The |
Contributor
Author
|
The main downside to this change is it grows the binary size. For x64, it increases 2% from 4.14 MB to 4.24 MB. |
|
I suppose 0.1 MB is negligible here... An immediately usable binary is much better than having to find and download the venerable Visual C++ Redistributable in emergency. |
BurntSushi
approved these changes
May 31, 2021
Owner
BurntSushi
left a comment
There was a problem hiding this comment.
I love this, thank you! I'll also update the README which IIRC mentions installing vcruntime or similar.
BurntSushi
pushed a commit
that referenced
this pull request
May 31, 2021
Before this change, rg.exe depended on vcruntime140.dll, which does not exist on a fresh install of Windows. Closes #1613
BurntSushi
pushed a commit
that referenced
this pull request
Jun 1, 2021
Before this change, rg.exe depended on vcruntime140.dll, which does not exist on a fresh install of Windows. Closes #1613
This was referenced Jan 12, 2022
vthib
added a commit
to vthib/boreal
that referenced
this pull request
Dec 3, 2022
See BurntSushi/ripgrep#1613 for explanations.
vthib
added a commit
to vthib/boreal
that referenced
this pull request
Dec 4, 2022
See BurntSushi/ripgrep#1613 for explanations.
vthib
added a commit
to vthib/boreal
that referenced
this pull request
Dec 4, 2022
See BurntSushi/ripgrep#1613 for explanations.
vthib
added a commit
to vthib/boreal
that referenced
this pull request
Dec 4, 2022
See BurntSushi/ripgrep#1613 for explanations.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, rg.exe depended on vcruntime140.dll, which does not exist on a fresh install of Windows. The missing DLL prevents rg.exe from starting.