Use SHA instead of Docker version tag for base image to allow for consistent code execution.#60
Merged
Burnett01 merged 2 commits intoBurnett01:release/7.0.1from Mar 31, 2024
Conversation
Release/7.0.0
…sistent code execution.
Owner
|
Hi @XComp Thank you very much for your contribution and I fully agree 👍🏾 |
Burnett01
approved these changes
Mar 30, 2024
Owner
Burnett01
left a comment
There was a problem hiding this comment.
reviewed and checked the hash against hub.
ref: https://hub.docker.com/layers/drinternet/rsync/v1.4.4/images/sha256-15b2949838074bd93c49421c22380396a0cd53a322439e799ac87afcadcfe234?context=explore
Owner
|
LGTM into release 7.0.1 |
Merged
Burnett01
added a commit
that referenced
this pull request
Mar 31, 2024
- Pin @JoshPiper [drinternet/rsync](https://github.com/JoshPiper/rsync-docker) image by SHA-256 hash rather than version. (Immutability) Added via #60 The docker image of this action is now pinned to the specific SHA-256 hash of the version rather than just the version. This means for the latest `drinternet/rsync:v1.4.4` the corresponding hash is `drinternet/rsync@sha256:15b2949838074bd93c49421c22380396a0cd53a322439e799ac87afcadcfe234` Check for validation: https://hub.docker.com/layers/drinternet/rsync/v1.4.4/images/sha256-15b2949838074bd93c49421c22380396a0cd53a322439e799ac87afcadcfe234 With that, usage of this action is even more secure due to a consistent dependency chain of trust, since changes accompanied by a docker image hash are immutable. Thanks to @XComp
Burnett01
added a commit
that referenced
this pull request
Jul 1, 2024
Use SHA instead of Docker version tag for base image to allow for consistent code execution.
Burnett01
added a commit
that referenced
this pull request
Jul 1, 2024
- Pin @JoshPiper [drinternet/rsync](https://github.com/JoshPiper/rsync-docker) image by SHA-256 hash rather than version. (Immutability) Added via #60 The docker image of this action is now pinned to the specific SHA-256 hash of the version rather than just the version. This means for the latest `drinternet/rsync:v1.4.4` the corresponding hash is `drinternet/rsync@sha256:15b2949838074bd93c49421c22380396a0cd53a322439e799ac87afcadcfe234` Check for validation: https://hub.docker.com/layers/drinternet/rsync/v1.4.4/images/sha256-15b2949838074bd93c49421c22380396a0cd53a322439e799ac87afcadcfe234 With that, usage of this action is even more secure due to a consistent dependency chain of trust, since changes accompanied by a docker image hash are immutable. Thanks to @XComp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're using this action for Apache Flink where we're required to review any custom actions. Fixing the base image version with the SHA256 hash instead of a version to would allow us to make sure that we're always execute the code that was reviewed.