Skip to content

Ms main#723

Merged
Bryan-Roe merged 3 commits intomainfrom
MS-main
May 23, 2025
Merged

Ms main#723
Bryan-Roe merged 3 commits intomainfrom
MS-main

Conversation

@Bryan-Roe
Copy link
Collaborator

Motivation and Context

Description

Contribution Checklist

  • The code builds clean without any errors or warnings
  • The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
  • All unit tests pass, and I have added new tests where possible
  • I didn't break anyone 😄
  • I have updated the documentation as needed
  • I have added appropriate labels to the PR
  • I have reviewed the code for any security vulnerabilities
  • I have considered the impact of my changes on the community and have included necessary updates to the COMMUNITY.md file
  • I have followed the checklist to ensure my code meets the project's standards and requirements

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request #723 has too many files changed.

We can only review pull requests with up to 300 changed files, and this pull request has 3372.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 18, 2025

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Latest Commit Updated (UTC)
❌ Deployment failed 501950c May 18 2025, 09:47 AM

@Bryan-Roe Bryan-Roe self-assigned this May 18, 2025
@Bryan-Roe Bryan-Roe requested a review from Copilot May 22, 2025 22:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates and adds multiple GitHub workflow configurations and supporting files for CI/CD, testing, and release processes in the semantic-kernel repo.

  • Updates cache settings and version dependencies for Python and .NET workflows.
  • Introduces new workflows for manual releases, integration tests (including multi-modality and agents), PR description generation, and label management.
  • Adjusts configuration and typo settings in auxiliary files such as _typos.toml and issue templates.

Reviewed Changes

Copilot reviewed 4846 out of 4846 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
.github/workflows/python-test-coverage.yml Added cache-dependency-glob configuration for caching uv.lock.
.github/workflows/python-test-coverage-report.yml Updated the pytest-coverage-comment action version.
.github/workflows/python-manual-release.yml New workflow for triggering ADO pipelines.
.github/workflows/python-lint.yml Added cache-dependency-glob configuration.
.github/workflows/python-integration-tests.yml Expanded integration tests with new jobs and disabled unstable Ollama tests.
.github/workflows/python-build.yml Updated permissions and added Azure CLI login for release jobs.
.github/workflows/markdown-link-check.yml Enabled persist-credentials set to false for checkout.
.github/workflows/label*.yml Added new labeler, issue creation, and discussion labeling workflows.
.github/workflows/generate-pr-description.yml Updated commit status action version.
.github/workflows/dotnet-*.yml Updated and added persist-credentials and improved caching/build settings.
.github/_typos.toml Expanded typo exclusion list with additional file patterns and terms.
.github/ISSUE_TEMPLATE/bug_report.md Expanded platform details with additional fields.
.github/.linkspector.yml Updated link ignore patterns and excluded files/directories.

@Bryan-Roe Bryan-Roe requested a review from Copilot May 22, 2025 22:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces numerous updates to the GitHub workflows by refining caching strategies, updating dependency versions, and adding new workflows for manual releases, labeling, and integration tests for both Python and .NET.

  • Added a "cache-dependency-glob" setting to various workflows to include the uv.lock file.
  • Upgraded several GitHub Actions (e.g. set-commit-status and notify-microsoft-teams) and disabled unstable Ollama tests with clear comments.
  • New workflows have been added to support manual releases and enhanced labeling processes.

Reviewed Changes

Copilot reviewed 4846 out of 4846 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
.github/workflows/python-test-coverage.yml Added caching for uv.lock to help manage dependency updates.
.github/workflows/python-test-coverage-report.yml Updated pytest coverage-comment action to a stable version (v1.1.53).
.github/workflows/python-manual-release.yml Introduced a new workflow to trigger ADO pipelines for Python releases.
.github/workflows/python-lint.yml Added caching enhancements similar to other Python workflows.
.github/workflows/python-integration-tests.yml Extended environment variables and added jobs for multi-modality and agent integration tests; disabled unstable Ollama tests.
.github/workflows/python-build.yml Enhanced permissions and added Azure login steps for triggering release pipelines.
.github/workflows/markdown-link-check.yml Included a persist-credentials flag for improved link checking.
.github/workflows/label.yml Added a new labeler workflow with configuration file validation.
.github/workflows/label-needs-port.yml Created a workflow to generate new issues when specific porting labels are applied.
.github/workflows/label-discussions.yml Launched a workflow to automatically label discussions based on content.
.github/workflows/generate-pr-description.yml Updated action versions for setting commit statuses.
.github/workflows/dotnet-integration-tests.yml Tweaked credentials management and added connection strings for Azure integrations.
.github/workflows/dotnet-format.yml Introduced .NET 9.0 testing and updated checkout credentials.
.github/workflows/dotnet-ci.yml Applied persist-credentials improvements during checkout.
.github/workflows/dotnet-build-and-test.yml Adjusted integration tests to exclude specific projects and upgraded coverage reporting.
.github/workflows/codeql-analysis.yml Added dispatch triggers and persist-credentials for CodeQL scans.
.github/_typos.toml Extended file exclusion lists and added new typographical identifiers.
.github/ISSUE_TEMPLATE/bug_report.md Revised bug report template fields to include additional context (e.g. AI model details).
.github/.linkspector.yml Updated link patterns and file/directory exclusions for improved link checking.

@Bryan-Roe Bryan-Roe requested a review from Copilot May 23, 2025 19:56
@Bryan-Roe Bryan-Roe added the help wanted Extra attention is needed label May 23, 2025
@Bryan-Roe Bryan-Roe added this to the Code Builds Clean milestone May 23, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR, titled "Ms main", introduces several updates and improvements to the CI/CD workflows and configuration files to modernize and streamline the automation processes within the repository. Key changes include:

  • Addition of new workflow files (e.g. for manual releases, label management, and discussion labeling) and updates to existing workflows.
  • Updates to action versions, caching settings (including new cache-dependency-glob settings), and environment variable configurations.
  • Minor tweaks in issue templates, typo configurations, and link-checker settings to enhance consistency.

Reviewed Changes

Copilot reviewed 4925 out of 4925 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
.github/workflows/python-test-coverage.yml Added cache-dependency-glob entry for uv.lock.
.github/workflows/python-test-coverage-report.yml Updated pytest coverage comment action version to v1.1.53.
.github/workflows/python-manual-release.yml New release workflow added.
.github/workflows/python-lint.yml Updated the cancellation check syntax and cache settings.
.github/workflows/python-integration-tests.yml Added environment variables and multiple integration test jobs.
.github/workflows/python-build.yml Updated permissions and added release pipeline trigger steps.
.github/workflows/markdown-link-check.yml Adjusted checkout settings.
.github/workflows/label*.yml New workflows for labeling issues, pull requests and discussions.
.github/workflows/generate-pr-description.yml Upgraded commit status action to v2.0.1.
.github/workflows/dotnet-*.yml Updates across dotnet workflows including format, CI, build, integration tests, and code analysis.
.github/_typos.toml Extended list of ignored typos.
.github/ISSUE_TEMPLATE/bug_report.md Updated issue template details.
.github/.linkspector.yml Updated link patterns and exclusions.

@Bryan-Roe Bryan-Roe requested a review from Copilot May 23, 2025 19:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates various GitHub workflow configurations and CI/CD pipelines for the semantic-kernel repo. Key changes include updates to caching settings and action versions (e.g. specifying cache-dependency-glob and updating action versions), addition of new integration test jobs for multi-modality and agents, and several new workflows for labeling, PR description generation, and issue creation.

Reviewed Changes

Copilot reviewed 4925 out of 4925 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.github/workflows/python-test-coverage.yml Added cache-dependency-glob setting for uv.lock caching.
.github/workflows/python-test-coverage-report.yml Updated pytest-coverage-comment action version.
.github/workflows/python-manual-release.yml New workflow to start Python release via ADO pipeline.
.github/workflows/python-lint.yml Adjusted the job condition syntax and added cache-dependency-glob.
.github/workflows/python-integration-tests.yml Added new integration test jobs for multi-modality and agents; disabled unstable Ollama tests; added new environment variables.
.github/workflows/python-build.yml Updated environment and permission settings, and added Azure login/ADO pipeline trigger steps.
.github/workflows/markdown-link-check.yml Updated checkout step to disable credentials persistence.
.github/workflows/label*.yml Added new workflows for applying labels and creating port issues/discussions labels.
.github/workflows/generate-pr-description.yml Updated commit status action version.
.github/workflows/dotnet-*.yml Updated .NET testing, formatting, build, and CI workflows with added persist-credentials settings and version updates.
.github/_typos.toml Extended exclusion lists for link checking and updated internal word mappings.
.github/ISSUE_TEMPLATE/bug_report.md Added new platform fields including AI model and duplicate IDE/OS fields.
.github/.linkspector.yml Updated link ignore patterns and added file/directory exclusions.

@Bryan-Roe Bryan-Roe requested a review from Copilot May 23, 2025 20:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes caching across Python workflows, bumps several GitHub Action versions, introduces new manual release and labeling workflows, and extends Python integration testing with additional multi-modality and agent jobs.

  • Add cache-dependency-glob: "**/uv.lock" to Python workflow caching steps
  • Bump action versions (pytest-coverage-comment, notify-microsoft-teams, ReportGenerator, set-commit-status-action, etc.)
  • Introduce python-manual-release.yml, label.yml, label-needs-port.yml, label-discussions.yml workflows
  • Extend python-integration-tests.yml with multi-modality and agent test jobs

Reviewed Changes

Copilot reviewed 4925 out of 4925 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.github/workflows/python-test-coverage.yml Add dependency glob for uv.lock caching
.github/workflows/python-test-coverage-report.yml Pin pytest-coverage-comment action to v1.1.53
.github/workflows/python-manual-release.yml New workflow for manual Python release via Azure DevOps
.github/workflows/python-lint.yml Fix if expression syntax and add uv.lock caching
.github/workflows/python-integration-tests.yml Add extra env vars, uv.lock caching, new multi-modality/agent jobs
.github/workflows/python-build.yml Add permissions, uv.lock caching, Azure login and pipeline trigger
.github/workflows/markdown-link-check.yml Disable credential persistence for checkout
.github/workflows/label.yml New generic PR labeler workflow
.github/workflows/label-needs-port.yml New workflow to open porting issues based on labels
.github/workflows/label-discussions.yml New workflow to label discussions by content
.github/workflows/generate-pr-description.yml Pin set-commit-status-action to v2.0.1
.github/workflows/dotnet-integration-tests.yml Add persist-credentials: false and new AzureAI var
.github/workflows/dotnet-format.yml Include .NET 9.0, disable checkout credential persistence
.github/workflows/dotnet-ci.yml Disable checkout credential persistence
.github/workflows/dotnet-build-and-test.yml Disable checkout persistence, update .NET test flags, ReportGenerator upgrade
.github/workflows/codeql-analysis.yml Add workflow_dispatch trigger, restrict feature* branches
.github/_typos.toml Extend typo exclusions
.github/ISSUE_TEMPLATE/bug_report.md Add AI model, reorder IDE/OS entries
.github/.linkspector.yml Update ignore patterns and excluded files/dirs
Comments suppressed due to low confidence (3)

.github/workflows/label-discussions.yml:9

  • [nitpick] The job ID label_discussions uses an underscore, while other workflows use hyphens for job IDs. Rename to label-discussions for consistency.
label_discussions:

.github/workflows/python-manual-release.yml:20

  • [nitpick] The step name Azure Login is inconsistent with other workflows that use Azure CLI Login. Consider renaming for clarity.
      - name: Azure Login

.github/.linkspector.yml:9

  • The localhost ignore patterns were removed above but only re‐added for some hosts. You may see link-check failures for localhost links. Re-add ^http://localhost and ^https://localhost to ignorePatterns.
-  - pattern: "^http://localhost"

@Bryan-Roe Bryan-Roe requested a review from Copilot May 23, 2025 20:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates and enhances several GitHub workflow files to improve CI/CD processes for the Semantic Kernel repository. Key changes include updating action versions and caching configuration, adding new jobs for release and integration tests, and refining label and link-check workflows.

Reviewed Changes

Copilot reviewed 4925 out of 4925 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.github/workflows/python-test-coverage.yml Added cache-dependency-glob configuration for UV lock files.
.github/workflows/python-test-coverage-report.yml Updated pytest coverage comment action to v1.1.53.
.github/workflows/python-manual-release.yml Added a workflow to trigger Azure DevOps pipeline on release.
.github/workflows/python-lint.yml Corrected the expression used in the if condition.
.github/workflows/python-integration-tests.yml Added and updated several integration test jobs and steps, with adjustments to disable unstable Ollama tests.
.github/workflows/python-build.yml Updated permissions and cache settings, and added Azure steps to trigger DevOps pipeline.
.github/workflows/markdown-link-check.yml Enabled persist-credentials: false on checkout.
.github/workflows/label*.yml and related Added new label workflows for pull requests, issues, and discussions.
.github/workflows/dotnet-* Updated CI/CD workflows for .NET including new target versions, caching enhancements, and test configuration modifications.
.github/_typos.toml & ISSUE_TEMPLATE Minor updates to typos and bug report templates.
.github/.linkspector.yml Modified ignored patterns and added new file/dir exclusions.
Comments suppressed due to low confidence (1)

.github/workflows/dotnet-build-and-test.yml:114

  • Forcing the target framework to net8.0 may unintentionally break tests expecting a different framework version. Please verify that this change aligns with the intended build configuration.
dotnet test -f net8.0 -c ${{ matrix.configuration }} $project --no-build -v Normal --logger trx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Bryan <74067792+Bryan-Roe@users.noreply.github.com>
@Bryan-Roe Bryan-Roe requested a review from Copilot May 23, 2025 21:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes and enhances various GitHub Actions workflows across Python and .NET projects by updating action versions, improving caching, adding new release and pre-merge integration test jobs, disabling unstable tests, and introducing labeling and link-checking automations.

  • Update action versions and add cache-dependency-glob for consistent caching of uv.lock
  • Introduce Python manual release trigger, new pre-merge integration test jobs, and disable unstable Ollama tests
  • Add labeler workflows, refine link-check config, update issue template, and adjust .NET workflows for credential persistence

Reviewed Changes

Copilot reviewed 4926 out of 4926 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/python-build.yml Added cache-dependency-glob, environment, but references undefined matrix.python-version
.github/workflows/python-integration-tests.yml Added multi-modality and agents jobs; disabled Ollama tests
.github/workflows/label-needs-port.yml Step for Python port issue has incorrect title text
.github/ISSUE_TEMPLATE/bug_report.md Duplicated and reordered list items for OS/IDE entries
Comments suppressed due to low confidence (2)

.github/workflows/python-build.yml:27

  • This job doesn’t define a strategy.matrix, so matrix.python-version is undefined. Use the UV_PYTHON environment variable (e.g., ${{ env.UV_PYTHON }}) or hardcode the Python version.
cache-suffix: ${{ runner.os }}-${{ matrix.python-version }}

.github/workflows/label-needs-port.yml:57

  • In the Create python issue step, the title still says Port dotnet feature:. It should be Port python feature: to match the step’s purpose.
--title "Port dotnet feature: ${{ github.event.issue.title || github.event.pull_request.title }}"

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Bryan <74067792+Bryan-Roe@users.noreply.github.com>
@Bryan-Roe Bryan-Roe requested a review from Copilot May 23, 2025 21:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes and enhances the repository’s CI/CD workflows by improving caching, pinning action versions, extending integration test coverage, and adding new release and labeling automations.

  • Add cache-dependency-glob: "**/uv.lock" to uv-based caching steps across Python workflows.
  • Pin GitHub Action versions (e.g., pytest-coverage-comment@v1.1.53, notify-microsoft-teams@v1.0.9, ReportGenerator@5.4.4).
  • Introduce new workflows for manual Python releases (python-manual-release.yml) and automated labeling (label.yml, label-needs-port.yml, label-discussions.yml), and expand the Python integration test matrix (multi-modality, agents) while disabling unstable Ollama tests.

Reviewed Changes

Copilot reviewed 4926 out of 4926 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.github/workflows/python-test-coverage.yml Added uv.lock globbing to cache-dependency-glob
.github/workflows/python-test-coverage-report.yml Bumped pytest-coverage-comment action to v1.1.53
.github/workflows/python-manual-release.yml New workflow to trigger Azure DevOps pipeline for Python release
.github/workflows/python-lint.yml Fixed cancellation condition syntax and added uv.lock caching
.github/workflows/python-integration-tests.yml Expanded env vars, added multi-modality/agents tests, disabled Ollama
.github/workflows/python-build.yml Added permissions, Azure release pipeline trigger, uv.lock cache
.github/workflows/markdown-link-check.yml Disabled credential persistence for link checker checkout
.github/workflows/label.yml New PR labeler workflow
.github/workflows/label-needs-port.yml New workflow to open porting issues upon specific labels
.github/workflows/label-discussions.yml New discussion labeling workflow
.github/workflows/generate-pr-description.yml Pinned set-commit-status-action to v2.0.1
.github/workflows/dotnet-integration-tests.yml Disabled credential persistence and added AzureAI ConnectionString
.github/workflows/dotnet-format.yml Added .NET 9.0 in matrix and disabled credential persistence
.github/workflows/dotnet-ci.yml Disabled credential persistence on checkout steps
.github/workflows/dotnet-build-and-test.yml Disabled credential persistence, excluded vector test, target net8.0, upload coverage
.github/workflows/codeql-analysis.yml Added workflow_dispatch trigger and disabled feature* branch
.github/_typos.toml Extended ignore lists for typos checks
.github/ISSUE_TEMPLATE/bug_report.md Added “AI model” field to bug report template
.github/.linkspector.yml Updated ignore patterns and excluded files/directories
Comments suppressed due to low confidence (3)

.github/workflows/label-needs-port.yml:58

  • [nitpick] The --label "python" value uses lowercase but project labels elsewhere use title case (e.g., ".NET"). Consider capitalizing "Python" to match the repository’s label casing convention.
--label "python" \

.github/workflows/python-integration-tests.yml:368

  • This job had its environment: "integration" property removed, while other pre-merge integration jobs retain it. Consider restoring the environment setting for consistency and to ensure correct environment variables are scoped.
-    environment: "integration"

.github/ISSUE_TEMPLATE/bug_report.md:33

  • The new checklist item is indented with only one space before the dash, which misaligns it with the other list items. It should use two spaces before the dash to match the existing format.
- AI model: [e.g. OpenAI:GPT-4o-mini(2024-07-18)]

@Bryan-Roe Bryan-Roe requested a review from Copilot May 23, 2025 21:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates and expands CI/CD workflows across Python and .NET, refines caching and action versions, and introduces new automation for releases and labeling.

  • Added cache-dependency-glob: "**/uv.lock" to Python workflows and corrected conditional syntax in lint job.
  • Bumped versions of several GitHub Actions (e.g., pytest-coverage-comment, notify-microsoft-teams, set-commit-status-action, ReportGenerator).
  • Introduced new workflows for Python manual releases, automated labeling, and extended integration test configurations (disabled unstable Ollama tests, added multi-modality/agents jobs).

Reviewed Changes

Copilot reviewed 4926 out of 4926 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.github/workflows/python-test-coverage.yml Added cache-dependency-glob for uv.lock in setup-uv step.
.github/workflows/python-test-coverage-report.yml Updated pytest-coverage-comment action to v1.1.53.
.github/workflows/python-manual-release.yml Added a workflow to trigger ADO Python release via workflow_dispatch.
.github/workflows/python-lint.yml Fixed if syntax and added cache-dependency-glob for uv.lock.
.github/workflows/python-integration-tests.yml Expanded environment vars, disabled unstable Ollama tests, and added merge-gate jobs for multi-modality and agents.
.github/workflows/python-build.yml Centralized permissions, added environment, caching tweak, and ADO pipeline trigger.
.github/workflows/markdown-link-check.yml Set persist-credentials: false on checkout step.
.github/workflows/label.yml New labeler workflow for pull requests.
.github/workflows/label-needs-port.yml New workflow to auto-create porting issues.
.github/workflows/label-discussions.yml New discussion-labeling workflow with GraphQL mutations.
.github/workflows/generate-pr-description.yml Updated set-commit-status-action to v2.0.1.
.github/workflows/dotnet-integration-tests.yml Added persist-credentials: false, and AzureAI__ConnectionString.
.github/workflows/dotnet-format.yml Added .NET 9.0 to matrix and persist-credentials: false.
.github/workflows/dotnet-ci.yml Added persist-credentials: false on multiple checkout steps.
.github/workflows/dotnet-build-and-test.yml Excluded specific tests, enforced -f net8.0, updated ReportGenerator, and upload coverage artifact.
.github/workflows/codeql-analysis.yml Added workflow_dispatch, adjusted branches, and persist-credentials.
.github/_typos.toml Extended exclude patterns and custom words.
.github/ISSUE_TEMPLATE/bug_report.md Added “AI model” field to bug report template.
.github/.linkspector.yml Expanded ignore patterns, excluded files and directories.
Comments suppressed due to low confidence (3)

.github/.linkspector.yml:9

  • The double dash (- -) introduces an extra sequence level and likely breaks the YAML structure. It should be a single - pattern: '^http://localhost' entry aligned with the others.
-  - pattern: "^http://localhost"

.github/.linkspector.yml:10

  • Same issue as above: remove the extra dash so it aligns as - pattern: '^https://localhost' under ignorePatterns.
-  - pattern: "^https://localhost"

.github/ISSUE_TEMPLATE/bug_report.md:33

  • [nitpick] The bullet indentation is inconsistent with the other list items (it has one space before the dash instead of two). Adjust to - AI model: … for proper Markdown nesting.
 + - AI model: [e.g. OpenAI:GPT-4o-mini(2024-07-18)]

@Bryan-Roe Bryan-Roe merged commit 89cd384 into main May 23, 2025
@Bryan-Roe Bryan-Roe deleted the MS-main branch May 23, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants