Skip to content

replace all obsolete appeal variable (Py3)#78

Merged
Bronya-Rand merged 1 commit intoBronya-Rand:python-3from
JimenezLi:py3-remove-appeal
Mar 12, 2024
Merged

replace all obsolete appeal variable (Py3)#78
Bronya-Rand merged 1 commit intoBronya-Rand:python-3from
JimenezLi:py3-remove-appeal

Conversation

@JimenezLi
Copy link
Copy Markdown
Contributor

This PR is a continuation of #68. The better poemgame replaces *_appeal variables with chibi_*.appeal, but the *_appeal variables are also used in other scripts.

I replace all *_appeal variables with chibi_*.appeal. Otherwise, the game raises an exception like NameError: 's_appeal' is not defined.

I am not sure if I should modify Original Script Files. If they shouldn't be modified, I shall revert those changes. Also I plan to make another PR for python-2 branch.

@Bronya-Rand Bronya-Rand merged commit 8172b36 into Bronya-Rand:python-3 Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants