You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
if it works, then go for it
there are a couple things that i ain't happy with tho
-the exec part straight up won't work.
instead of storing the appeals in a list, add a new parameter name to the Chibi constructor and store the object in a dict with the name as its key. that way you can replace this ugly exec with chibis[ch1_choice[0]].charPointTotal += 5
-goofy ahh sorting code poemwinner[chapter] = max(chibis, key=lambda c: chibis[c].charPointTotal ) works way better (with the dict thing i talked about just before)
plus the code won't work if there are more than 3 appeals
This is a much needed change, and I'll contribute however I can because the vanilla code is just painful to look at
Maybe you could salvage something from this incomplete mess https://github.com/dokimods/poemgame
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following
ui.XfunctionsChibiclass (orChibiTransif you don't need points).(Elk, if by any chance you read this PR, get some water and a pillow because you might rage at this.)