Preliminary s3 driver implementation#3
Merged
BrianBland merged 3 commits intoBrianBland:next-generationfrom Oct 27, 2014
AndreyKostov:next-generation
Merged
Preliminary s3 driver implementation#3BrianBland merged 3 commits intoBrianBland:next-generationfrom AndreyKostov:next-generation
BrianBland merged 3 commits intoBrianBland:next-generationfrom
AndreyKostov:next-generation
Conversation
storagedriver/s3/s3.go
Outdated
Owner
There was a problem hiding this comment.
We should probably validate that we have write access to the bucket on driver creation if possible.
734fda5 to
3f95694
Compare
1c68bdb to
7c892de
Compare
BrianBland
added a commit
that referenced
this pull request
Oct 27, 2014
Preliminary s3 driver implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE (uses goamz, which is lgpl)
Will have to use https://github.com/smartystreets/go-aws-auth or something else in the future.