config: enable c14 by default#1016
Merged
BrettMayson merged 3 commits intounusedExternfrom Jun 25, 2025
Merged
Conversation
Collaborator
|
I still am not sure if c14 is useful |
PabstMirror
reviewed
Jun 25, 2025
PabstMirror
approved these changes
Jun 25, 2025
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
BrettMayson
added a commit
that referenced
this pull request
Jun 26, 2025
* config: C14 Check unused externs * indexmap, add test * clippy * config: enable c14 by default (#1016) * config: enable c14 by default * change message * Update bin/src/commands/check.rs Co-authored-by: PabstMirror <pabstmirror@gmail.com> --------- Co-authored-by: PabstMirror <pabstmirror@gmail.com> * Always create .hemttout (for testing) --------- Co-authored-by: BrettMayson <brett@mayson.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to the unused stringtables
If we go this way instead, do we want to add paths to ignore?
I'm also ok reverting the -Lc14 thing, to be honest I started that, then remembered txt files exist, and did both, but I don't think we need it. it changes the lints to pass RuntimeArguments rather than just the bool for pedantic, and those arguments are passed down to the lints, means every lint needs to be modified to add that, but we can reuse that in the future to pass more runtime info down to the lints if needed
Only going to bother with tests if you're ok going this way