Conversation
This was referenced Jul 30, 2024
nickpalladino
approved these changes
Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-1692 - Change role names
Updated front end logic to use new role domains:
Changed RolePermissions in ability.ts to utilize new domains
Dependencies
bi-api: feature/BI-1692
Testing
Ensure a user can can log in as:
System User Table
Program User Table
Check that proper role names display in role column
Check that role dropdown for edit and adding a user now properly displays the new domains and that those value scan be selected
Check that a user can be added to a program as Program Administrator
Check that a user can be added to a program as Read Only
Check that a program user's role can be successfully edited
Miscellaneous smoke testing regarding adding programs/uploading files to ensure permissions properly updated after domain changes
Checklist: