Skip to content

[BI-1692] - Change role names#388

Merged
HMS17 merged 8 commits intodevelopfrom
feature/BI-1692
Aug 8, 2024
Merged

[BI-1692] - Change role names#388
HMS17 merged 8 commits intodevelopfrom
feature/BI-1692

Conversation

@HMS17
Copy link
Contributor

@HMS17 HMS17 commented Jul 19, 2024

Description

Story: BI-1692 - Change role names

Updated front end logic to use new role domains:

  • admin -> System Administrator
  • breeder -> Program Administrator
  • member -> Read Only

Changed RolePermissions in ability.ts to utilize new domains

  • This involved adding a helper method to remove whitespaces from domain names in order to convert domain names to rolePermissions function names

Dependencies

bi-api: feature/BI-1692

Testing

Ensure a user can can log in as:

  • System Administrator
  • Program Administrator
  • Read Only

System User Table

  • Check that System Administrator displays properly in role column
  • Check that role dropdown for edit and creating a user now properly displays System Administrator and that that value can be selected
  • Check that a user can be created with System Administrator role
  • Check that a non-self user's role can be edited to and from System Administrator role

Program User Table

  • Check that proper role names display in role column

  • Check that role dropdown for edit and adding a user now properly displays the new domains and that those value scan be selected

  • Check that a user can be added to a program as Program Administrator

  • Check that a user can be added to a program as Read Only

  • Check that a program user's role can be successfully edited

  • Miscellaneous smoke testing regarding adding programs/uploading files to ensure permissions properly updated after domain changes

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>

@HMS17 HMS17 requested review from a team, davedrp and nickpalladino and removed request for a team August 6, 2024 11:25
@HMS17 HMS17 marked this pull request as ready for review August 6, 2024 11:26
@HMS17 HMS17 requested review from mlm483 and removed request for davedrp August 7, 2024 14:59
@mlm483 mlm483 self-assigned this Aug 7, 2024
Copy link
Contributor

@mlm483 mlm483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working.

@HMS17 HMS17 merged commit 8a33a9d into develop Aug 8, 2024
@HMS17 HMS17 deleted the feature/BI-1692 branch August 8, 2024 13:13
@HMS17 HMS17 restored the feature/BI-1692 branch August 12, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants