Conversation
…-1692 # Conflicts: # src/main/java/org/breedinginsight/api/v1/controller/ProgramController.java # src/main/java/org/breedinginsight/api/v1/controller/UserController.java
6 tasks
4 tasks
nickpalladino
approved these changes
Aug 6, 2024
mlm483
approved these changes
Aug 7, 2024
Contributor
mlm483
left a comment
There was a problem hiding this comment.
Tested, working.
When you merge with develop, you'll notice that your migration version, 1.25.0, fits into an empty slow between the existing 1.24.0 and 1.26.0. In the logs on startup, there's a message that indicates this migration is applied "out of order" (pasted below), and indeed it worked fine. This should only happen on development anyway, the 1.26.0 migrations haven't been applied to production, because they're part of the same release, so there's really no issue. And there's no dependency between the migrations.
Current version of schema "public": 1.26.1
outOfOrder mode is active. Migration of schema "public" may not be reproducible.
Migrating schema "public" to version "1.25.0 - update roles" [out of order]
|
|
||
| searchRequest.setFilters(new ArrayList<>()); | ||
| searchRequest.getFilters().add(new FilterRequest("roles", "breed")); | ||
| searchRequest.getFilters().add(new FilterRequest("roles", "Program Administrator")); |
Contributor
There was a problem hiding this comment.
Any idea why this was "breed" and not "breeder" before?
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-1692 - Change role names
Added migration to update role domains:
Changed logic to reflect role domain change in the following locations:
Dependencies
bi-web: feature/BI-1692
Testing
(see bi-web)
Checklist: