BI-1721 - Show All - Breeding Methods table#303
Merged
timparsons merged 3 commits intodevelopfrom Mar 16, 2023
Merged
Conversation
6 tasks
dmeidlin
requested changes
Mar 6, 2023
Contributor
dmeidlin
left a comment
There was a problem hiding this comment.
Both "Germplasm" and "Experiments&Observations" are stuck in a recursive loop that keeps making requests to the back end.
Comment on lines
44
to
45
| constructor(paginationResult?: any) { | ||
| if (paginationResult){ |
Contributor
There was a problem hiding this comment.
Starting TSv2.2 the object type is used for generic objects. We should probably start using object or object | null in place of any when appropriate.
Member
Author
There was a problem hiding this comment.
This makes sense. For this specific instance, I tried changing it to object, then had other compilation errors. If you're ok with it, I'd rather not change this now.
davedrp
approved these changes
Mar 9, 2023
Member
Author
@dmeidlin Good catch! This has been fixed |
dmeidlin
approved these changes
Mar 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: https://breedinginsight.atlassian.net/browse/BI-1721
Original bug was that the "Show All" button wasn't working for the Breeding Methods table. When investigating how to fix this, there was a lot of duplicate and confusing code around pagination, so I refactored that to utilize
PaginationControllerand the mechanism for a parent component to update page information as needed, and for theExpandableTablecomponent to now be primarily responsible for handling paging events from thePaginationControls.Dependencies
bi-api - bug/BI-1721
Testing
Testing applies to the all tables:
Checklist: