Skip to content

BI-1721 - Show All - Breeding Methods table#242

Merged
timparsons merged 1 commit intodevelopfrom
bug/BI-1721
Mar 16, 2023
Merged

BI-1721 - Show All - Breeding Methods table#242
timparsons merged 1 commit intodevelopfrom
bug/BI-1721

Conversation

@timparsons
Copy link
Member

Description

Story: https://breedinginsight.atlassian.net/browse/BI-1721

When trying to enable system breeding methods, and a given program has previously created a custom breeding method, an error was thrown stating "Breeding method is not allowed to be edited". This was due to the program custom breeding method being included in the check for editability when it should not have been.

Dependencies

bi-web: bug/BI-1721

Testing

  1. For a given program, on the Breeding Methods config page
  2. Enable a subset of system methods
  3. Create a new program custom breeding method
  4. Enable all system methods, and ensure this succeeds

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation

@github-actions github-actions bot added the bug Something isn't working label Feb 28, 2023
@timparsons timparsons assigned dmeidlin and davedrp and unassigned dmeidlin Feb 28, 2023
@timparsons timparsons force-pushed the bug/BI-1721 branch 2 times, most recently from ae880d4 to 097ca13 Compare March 13, 2023 15:45
@timparsons timparsons merged commit db343d1 into develop Mar 16, 2023
@timparsons timparsons deleted the bug/BI-1721 branch March 16, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants