Skip to content

[BI-1613] - Add Term Type to Ontology Term Import#287

Merged
nickpalladino merged 5 commits intodevelopfrom
feature/BI-1613
Jan 18, 2023
Merged

[BI-1613] - Add Term Type to Ontology Term Import#287
nickpalladino merged 5 commits intodevelopfrom
feature/BI-1613

Conversation

@HMS17
Copy link
Contributor

@HMS17 HMS17 commented Dec 7, 2022

Description

Story: BI-1613 - Add Term Type to Ontology Term Import

Updated Ontology Import Preview table to include Term Type column
Updated Ontology Import Template button to download updated template version

Note: This is branched off of BI-1615, so until that is merged the changelist will include changes from that branch

Dependencies

bi-api/BI-1613

Testing

  • Open Ontology Batch Import
  • Click download template - ensure template downloaded is v13 and has term type column
  • Create ontology import using download template with blank and filled values for term type with different casing
  • Upload created file
  • Check import preview table displays correct term types for user inputted rows
  • Check import preview table displays "Phenotype" for rows where the user did not input a term type
  • Confirm import
  • Check that import works successfully and new ontology terms are displayed in table with correct term types

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>

@HMS17 HMS17 requested review from a team, nickpalladino and timparsons and removed request for a team December 12, 2022 15:28
@HMS17 HMS17 marked this pull request as ready for review December 14, 2022 14:04
@nickpalladino nickpalladino merged commit f03e08b into develop Jan 18, 2023
@nickpalladino nickpalladino deleted the feature/BI-1613 branch January 18, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants