[BI-1613] - Add Term Type to Ontology Term Import#233
Merged
nickpalladino merged 12 commits intodevelopfrom Jan 18, 2023
Merged
[BI-1613] - Add Term Type to Ontology Term Import#233nickpalladino merged 12 commits intodevelopfrom
nickpalladino merged 12 commits intodevelopfrom
Conversation
6 tasks
4 tasks
timparsons
requested changes
Dec 14, 2022
Comment on lines
+41
to
+48
| public static String nameFromUserDisplay(String userDisplay){ | ||
| for (TermTypeTranslator term: values()){ | ||
| if (term.userDisplay.equals(userDisplay)){ | ||
| return term.name(); | ||
| } | ||
| } | ||
| throw new IllegalArgumentException(); | ||
| } |
Member
There was a problem hiding this comment.
This can be simplified to return the enum that matches the userDisplay (and also remove the name from the enum terms)
Member
There was a problem hiding this comment.
I ended up just making a wrapper around a map and got rid of the additional enum which I think simplified things more. If in the future the conversion will go the other way, can iterate through or use a bidirectional map.
nickpalladino
approved these changes
Dec 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-1613 - Add Term Type to Ontology Term Import
Added TermTypeTranslator enum for ease of converting between user readable term type values and backend storage values
Added validation for term type in Ontology Import
Updated Ontology Import to save Term Type
Updated unit tests and corresponding files
Note: This is branched off of BI-1615, so until that is merged the changelist will include changes from that branch
Dependencies
bi-web/BI-1613
Testing
see bi-web
Checklist: