Conversation
2e9321c to
13d0243
Compare
7 tasks
timparsons
requested changes
Sep 15, 2022
Member
timparsons
left a comment
There was a problem hiding this comment.
Dev testing passed. Code looks good with one minor change request
| * @param femaleParentUnknown | ||
| * @param maleParentUnknown | ||
| */ | ||
| public static parsePedigreeStringWithUnknowns(pedigreeString: string, femaleParentUnknown: string, maleParentUnknown: string, gid: string) : Pedigree { |
Member
There was a problem hiding this comment.
It looks like the femaleParentUnknown and maleParentUnknown additionalInfo fields are booleans. Can the types of the parameters in this method can be updated to reflect this?
Contributor
Author
There was a problem hiding this comment.
Vue yells at me if I change the parameter type to boolean despite it being very clearly processed as a boolean in the method. It is strange.
Member
There was a problem hiding this comment.
Ok, thanks for looking into this!
timparsons
approved these changes
Sep 16, 2022
| * @param femaleParentUnknown | ||
| * @param maleParentUnknown | ||
| */ | ||
| public static parsePedigreeStringWithUnknowns(pedigreeString: string, femaleParentUnknown: string, maleParentUnknown: string, gid: string) : Pedigree { |
Member
There was a problem hiding this comment.
Ok, thanks for looking into this!
nickpalladino
approved these changes
Sep 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-1230 - Truly Unknown Germplasm
Updates to support importing germplasm with truly unknown parents without using a dummy parent. This development also ensures that unrelated germplasm with unknown parents are not falsely attributed as siblings in the pedigree view display.
To import a file with unknown parents, a GID or entry number of 0 must be used. Presently only both parents unknown or female parent known and male parent unknown are supported.
Unknown parents will be displayed as "Unknown" in the parent GID columns in the All Germplasm table and in the pedigree in Germplasm Details page.
Due to Breedbase limitations, parents with more than 10 progeny will cause the pedigree viewer to error (to be fixed in BI-1579.
Dependencies
bi-api/BI-1230
Testing
For both import with parent entry numbers and import with germplasm gids, import germplasm file with:
Check import occurs successfully
Check that Unknown is displayed in GID column for All Germplasm Table for germplasm with Unknown parent
Check that Unknown displayed in pedigree on Germplasm Details page for germplasm with Unknown parent
Look at pedigree viewer and expand generations, unknown parents should be displayed and be separate nodes from each other
Checklist: