Skip to content

[BI-1230] Truly Unknown Germplasm#205

Merged
HMS17 merged 7 commits intodevelopfrom
feature/BI-1230
Sep 21, 2022
Merged

[BI-1230] Truly Unknown Germplasm#205
HMS17 merged 7 commits intodevelopfrom
feature/BI-1230

Conversation

@HMS17
Copy link
Contributor

@HMS17 HMS17 commented Aug 17, 2022

Description

Story: BI-1230 - Truly Unknown Germplasm

Updates to support importing germplasm with truly unknown parents without using a dummy parent. This development also ensures that unrelated germplasm with unknown parents are not falsely attributed as siblings in the pedigree view display.

This included adding GET endpoint calls to /pedigree and /progeny in GermplasmController and adding additionalInfo items of femaleParentUnknown and maleParentUnknown on import. For import and display, the GID of an Unknown Parent is 0, but the backend endpoint retrieval labels an unknown parent GID as -F-Unknown or -M-Unknown, which is needed for maintaining information of pedigree connections for constructing the pedigree tree.

To import a file with unknown parents, a GID or entry number of 0 must be used. Presently only both parents unknown or female parent known and male parent unknown are supported.

Unknown parents will be displayed as "Unknown" in the parent GID columns in the All Germplasm table and in the pedigree in Germplasm Details page.

Due to Breedbase limitations, parents with more than 10 progeny will cause the pedigree viewer to error (to be fixed in BI-1579.

Dependencies

bi-web/BI-1230

Testing

see bi-web

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@HMS17 HMS17 marked this pull request as ready for review September 7, 2022 21:23
@HMS17 HMS17 requested review from a team, nickpalladino and timparsons and removed request for a team September 7, 2022 21:35
Copy link
Member

@timparsons timparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev testing passed

@HMS17 HMS17 merged commit 28fe6fc into develop Sep 21, 2022
@HMS17 HMS17 deleted the feature/BI-1230 branch September 21, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants