Skip to content

[BI-1199] - Choose file format for germplasm export#243

Merged
HMS17 merged 8 commits intodevelopfrom
feature/BI-1199
Jul 6, 2022
Merged

[BI-1199] - Choose file format for germplasm export#243
HMS17 merged 8 commits intodevelopfrom
feature/BI-1199

Conversation

@HMS17
Copy link
Contributor

@HMS17 HMS17 commented Jun 21, 2022

Description

Story: BI-1199 - Choose file format for germplasm export

Changes to frontend to enable modal selection of file type when downloading germplasm list and passing of user selection to backend.

Added new reusable modal component SelectModal that takes in title and a list of options to display, and utilized it to display file types upon user clicking download and pass that information on click.

Dependencies

bi-api/BI-1199

Testing

  • Open Germplasm List
  • Click Download
  • Verify modal pops up and shows
  • Verify each file type can be selected
  • Verify when cancel clicked the modal closes and nothing is downloaded
  • Verify for each file type (csv, xls, xlsx) that when it is selected and download is clicked the file is downloaded with the proper extension and the correct data

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>

@HMS17 HMS17 requested review from a team, davedrp and timparsons and removed request for a team June 22, 2022 21:33
@HMS17 HMS17 marked this pull request as ready for review June 22, 2022 21:33
@HMS17 HMS17 requested a review from ctucker3 June 27, 2022 16:47
Copy link
Contributor

@ctucker3 ctucker3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@HMS17 HMS17 requested a review from timparsons July 6, 2022 17:37
@HMS17 HMS17 merged commit b703125 into develop Jul 6, 2022
@HMS17 HMS17 deleted the feature/BI-1199 branch July 6, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants