[BI-1199] - Choose file format for germplasm export#193
Merged
Conversation
6 tasks
timparsons
requested changes
Jun 23, 2022
src/main/java/org/breedinginsight/brapi/v2/GermplasmController.java
Outdated
Show resolved
Hide resolved
src/main/java/org/breedinginsight/brapi/v2/services/BrAPIGermplasmService.java
Show resolved
Hide resolved
src/main/java/org/breedinginsight/brapi/v2/services/BrAPIGermplasmService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/breedinginsight/services/writers/CSVWriter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/breedinginsight/services/writers/ExcelWriter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/breedinginsight/services/writers/ExcelWriter.java
Outdated
Show resolved
Hide resolved
src/test/java/org/breedinginsight/utilities/response/FileUtilUnitTest.java
Outdated
Show resolved
Hide resolved
davedrp
approved these changes
Jun 30, 2022
ctucker3
approved these changes
Jun 30, 2022
timparsons
approved these changes
Jul 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-1199 - Choose file format for germplasm export
Refactoring file export logic to enable exporting to xls and csv formats
Modified ExcelWriter.java to write to xls as well as xlsx format
Added CSVWriter.java that takes in same data and columns as ExcelWriter but writes to a csv format
Added FileType enum to encompass information needed to write to each file type
Modified GermplasmController.java to take in file type and pass that on to BrAPIGermplasmService.java, which in turns calls the respective writer associated with the FileType
Dependencies
bi-web/BI-1199
Testing
see testing for bi-web
Checklist: