Skip to content

[BI-1199] - Choose file format for germplasm export#193

Merged
HMS17 merged 8 commits intodevelopfrom
feature/BI-1199
Jul 6, 2022
Merged

[BI-1199] - Choose file format for germplasm export#193
HMS17 merged 8 commits intodevelopfrom
feature/BI-1199

Conversation

@HMS17
Copy link
Contributor

@HMS17 HMS17 commented Jun 21, 2022

Description

Story: BI-1199 - Choose file format for germplasm export

Refactoring file export logic to enable exporting to xls and csv formats
Modified ExcelWriter.java to write to xls as well as xlsx format
Added CSVWriter.java that takes in same data and columns as ExcelWriter but writes to a csv format
Added FileType enum to encompass information needed to write to each file type
Modified GermplasmController.java to take in file type and pass that on to BrAPIGermplasmService.java, which in turns calls the respective writer associated with the FileType

Dependencies

bi-web/BI-1199

Testing

see testing for bi-web

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@HMS17 HMS17 requested review from davedrp and timparsons June 22, 2022 21:33
@HMS17 HMS17 changed the title [BI-1199] - Modal file selection fixes [BI-1199] - Choose file format for germplasm export Jun 22, 2022
@HMS17 HMS17 marked this pull request as ready for review June 22, 2022 22:35
@HMS17 HMS17 requested a review from ctucker3 June 27, 2022 16:47
@HMS17 HMS17 assigned ctucker3 and unassigned timparsons Jun 27, 2022
@HMS17 HMS17 requested a review from timparsons July 6, 2022 17:37
@HMS17 HMS17 merged commit bcac2f7 into develop Jul 6, 2022
@HMS17 HMS17 deleted the feature/BI-1199 branch July 6, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants