Conversation
dmeidlin
reviewed
Jul 24, 2024
Comment on lines
+116
to
+121
| Map<String, BrAPIObservation> mutatedObservationByDbId = new HashMap<>(); | ||
| List<BrAPIObservation> updatedObservations = new ArrayList<>(); | ||
| for (U member : members) { | ||
| BrAPIObservation observation = (BrAPIObservation) member; | ||
| Optional.ofNullable(brAPIObservationDAO.updateBrAPIObservation(observation.getObservationDbId(), observation, importContext.getProgram().getId())).ifPresent(updatedObservations::add); | ||
| mutatedObservationByDbId.put(observation.getObservationDbId(), observation); | ||
| // Optional.ofNullable(brAPIObservationDAO.updateBrAPIObservation(observation.getObservationDbId(), observation, importContext.getProgram().getId())).ifPresent(updatedObservations::add); |
Contributor
There was a problem hiding this comment.
Looks good. I would just delete all of this.
Contributor
Author
There was a problem hiding this comment.
I may be misunderstanding your comment, but mutatedObservationByDbId is used on line 124. If I delete lines 116-121 it will not be declared or populated.
Contributor
There was a problem hiding this comment.
Github doesn't let me compose a suggestion on deleted lines, so I had to put the replacement in my next comment below. The map is defined there.
Contributor
Author
There was a problem hiding this comment.
Thanks! I received your full comment in Slack and have implemented your suggestions.
dmeidlin
approved these changes
Jul 25, 2024
| } | ||
|
|
||
| return (List<U>) updatedObservations; | ||
| return (List<U>) brAPIObservationDAO.updateBrAPIObservation(mutatedObservationByDbId, importContext.getProgram().getId()); |
Contributor
There was a problem hiding this comment.
and add this
Suggested change
| return (List<U>) brAPIObservationDAO.updateBrAPIObservation(mutatedObservationByDbId, importContext.getProgram().getId()); | |
| Map<String, BrAPIObservation> mutatedObservationByDbId = members.stream().collect(Collectors.toMap( | |
| m -> ((BrAPIObservation) m).getObservationDbId(), | |
| m -> ((BrAPIObservation) m) | |
| )); | |
| return (List<U>) brAPIObservationDAO.updateBrAPIObservation(mutatedObservationByDbId, importContext.getProgram().getId()); |
Comment on lines
+116
to
+121
| Map<String, BrAPIObservation> mutatedObservationByDbId = new HashMap<>(); | ||
| List<BrAPIObservation> updatedObservations = new ArrayList<>(); | ||
| for (U member : members) { | ||
| BrAPIObservation observation = (BrAPIObservation) member; | ||
| Optional.ofNullable(brAPIObservationDAO.updateBrAPIObservation(observation.getObservationDbId(), observation, importContext.getProgram().getId())).ifPresent(updatedObservations::add); | ||
| mutatedObservationByDbId.put(observation.getObservationDbId(), observation); | ||
| // Optional.ofNullable(brAPIObservationDAO.updateBrAPIObservation(observation.getObservationDbId(), observation, importContext.getProgram().getId())).ifPresent(updatedObservations::add); |
Contributor
There was a problem hiding this comment.
Github doesn't let me compose a suggestion on deleted lines, so I had to put the replacement in my next comment below. The map is defined there.
Closed
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is just a merge, but it was originally branched of a pre-BI-2134 branch, it warrants retesting. Here is the original PR
Checklist: