Skip to content

Bug/bi 2093 - (Performance) Observation Cache Refreshing After Every PUT During Overwrite#365

Closed
davedrp wants to merge 3 commits intodevelopfrom
bug/BI-2093
Closed

Bug/bi 2093 - (Performance) Observation Cache Refreshing After Every PUT During Overwrite#365
davedrp wants to merge 3 commits intodevelopfrom
bug/BI-2093

Conversation

@davedrp
Copy link
Contributor

@davedrp davedrp commented Jun 20, 2024

Description

Bug/bi 2093 - (Performance) Observation Cache Refreshing After Every PUT During Overwrite

Modified code so ProgramCache.populate() is called only once (instead of once per updated observation as it was doing.)

Dependencies

bi-web: develop

Testing

  • Use Wireshark to track activity between bapi and the Java BrAPI Test Server (JBTS) while overwriting an experiment's observations [ I used the filter http && tcp.port == 8083 && http.request.method == POST where 8083 was the port on which JBTS is running. ]

  • Import an Experiment & Observation file that overwrites observations

EXPECTED RESULT
The http POST /brapi/v2/search/observations HTTP/1.1 , JSON (application/json) should be sent once.
ACTUAL RESULT
The http POST /brapi/v2/search/observations HTTP/1.1 , JSON (application/json) was sent once per overwritten observation.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@davedrp davedrp requested review from a team, dmeidlin and nickpalladino and removed request for a team June 20, 2024 17:45
@github-actions github-actions bot added the bug Something isn't working label Jun 20, 2024
@davedrp davedrp mentioned this pull request Jul 17, 2024
7 tasks
@davedrp
Copy link
Contributor Author

davedrp commented Jul 26, 2024

merged in PR #376

@davedrp davedrp closed this Jul 26, 2024
@davedrp davedrp deleted the bug/BI-2093 branch July 26, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants