Bug/bi 2093 - (Performance) Observation Cache Refreshing After Every PUT During Overwrite#365
Closed
Bug/bi 2093 - (Performance) Observation Cache Refreshing After Every PUT During Overwrite#365
Conversation
nickpalladino
approved these changes
Jun 24, 2024
dmeidlin
approved these changes
Jun 24, 2024
Contributor
Author
|
merged in PR #376 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bug/bi 2093 - (Performance) Observation Cache Refreshing After Every PUT During Overwrite
Modified code so ProgramCache.populate() is called only once (instead of once per updated observation as it was doing.)
Dependencies
bi-web: develop
Testing
Use Wireshark to track activity between bapi and the Java BrAPI Test Server (JBTS) while overwriting an experiment's observations [ I used the filter
http && tcp.port == 8083 && http.request.method == POSTwhere8083was the port on which JBTS is running. ]Import an Experiment & Observation file that overwrites observations
EXPECTED RESULT
The http
POST /brapi/v2/search/observations HTTP/1.1 , JSON (application/json)should be sent once.ACTUAL RESULT
The http
POST /brapi/v2/search/observations HTTP/1.1 , JSON (application/json)was sent once per overwritten observation.Checklist: