Skip to content

[BI-1146] change ‘Exp Trt Factor Name’ to ‘Treatment Factors’ - failed QA#197

Merged
davedrp merged 1 commit intofuture/1.0from
bug/BI-1146
Jul 20, 2022
Merged

[BI-1146] change ‘Exp Trt Factor Name’ to ‘Treatment Factors’ - failed QA#197
davedrp merged 1 commit intofuture/1.0from
bug/BI-1146

Conversation

@davedrp
Copy link
Contributor

@davedrp davedrp commented Jul 15, 2022

Description

Story:
1146 failed QA. The failure was Acceptance 1. The experiment import template still has a column for “Exp Trt Factor Name” instead of “Treatment Factors”.

Updated template. Updated display column name

Dependencies

bi-web branch bug/BI-1146

Testing

  1. Upload an Experiment with the column Exp Trt Factor Name. It should fail.
  2. Upload an Experiment with the column Treatment Factors. It should succeed.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>

@github-actions github-actions bot added the bug Something isn't working label Jul 15, 2022
@davedrp davedrp requested review from a team, HMS17 and dmeidlin and removed request for a team July 15, 2022 14:44
@davedrp davedrp marked this pull request as ready for review July 15, 2022 14:45
@@ -22,13 +22,11 @@
import java.util.List;

public interface BrAPIImport {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There doesn't seem to be any changes in this file?

@davedrp davedrp reopened this Jul 20, 2022
@davedrp davedrp merged commit 94a1381 into future/1.0 Jul 20, 2022
@davedrp davedrp deleted the bug/BI-1146 branch July 20, 2022 18:48
timparsons pushed a commit that referenced this pull request Aug 2, 2022
[BI-1146] change ‘Exp Trt Factor Name’ to ‘Treatment Factors’ - failed QA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants