nmodl: update package recipe#2332
Conversation
|
There are one or more issues with the title of this PR.
Please satisfy at least one of the checks (one package, docs, or deploy).
|
|
Thank you for your pull request! Should you want to clear the PR build directory after failures, please use this pipeline. Before running the cleanup pipeline, please ensure that any PR building pipelines have been cancelled or finished running. |
|
There are one or more issues with the commit message of commit a92b174.
Please satisfy at least one of the checks (one package, docs, or deploy).
|
a92b174 to
e3b31fa
Compare
| depends_on("py-pyyaml@3.13:", type=("build", "run")) | ||
| depends_on("spdlog") | ||
| depends_on("py-find-libpython", type=("run",)) | ||
| depends_on("py-importlib-resources", type=("run",), when="+python@:3.8") |
There was a problem hiding this comment.
Does this really work? Me thinks that should be when="+python ^python@3.8". 3.7 is already EOL!
I'm tempted to say we should just require 3.9+. End of year, that's going to be the minimum supported version anyways.
There was a problem hiding this comment.
should be
when="+python ^python@3.8"
Probably, I read the docs for a whole of 5 seconds beforehand 😅 NMODL doesn't even support 3.7.
Regarding Python 3.9, I have no strong opinions, I don't even have 3.8 on my machine, only 3.9 and later; does anyone actually use NMODL on master, but with Spack and 3.8? I see 3.8 is available on BB5, but have no idea what people use...
There was a problem hiding this comment.
BB5 has a default of 3.11
Ubuntu 20.04 has 3.8 by default, but some of our/NSE's software has already moved on. I would drop 3.8 to keep things simple, and maybe just add a
depends_on("python@3.9:")
to formalize that.
There was a problem hiding this comment.
(my Spack on Ubuntu 20.04 builds it's own Python 3.10 to avoid conflicts with the system packages, too)
|
To test your PR, use the following on BlueBrain5: unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/2332/config/modules.sh
module load unstable |
|
To test your PR, use the following on BlueBrain5: unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/2332/config/modules.sh
module load unstableThe following module tests failed: |
|
To test your PR, use the following on BlueBrain5: unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/2332/config/modules.sh
module load unstable |
Due to the merge of BlueBrain/nmodl#1166, we need to update the NMODL package recipe on Python 3.8.