Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

Remove deprecated pkg_resources#1166

Merged
JCGoran merged 13 commits into
masterfrom
jelic/remove_pkg_resources
Feb 28, 2024
Merged

Remove deprecated pkg_resources#1166
JCGoran merged 13 commits into
masterfrom
jelic/remove_pkg_resources

Conversation

@JCGoran

@JCGoran JCGoran commented Feb 22, 2024

Copy link
Copy Markdown
Contributor

The pkg_resources submodule of setuptools is deprecated, and importlib should be used instead (or its backports, importlib_metadata and importlib_resources).

@codecov

codecov Bot commented Feb 22, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.38%. Comparing base (9df433b) to head (8362dcc).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1166   +/-   ##
=======================================
  Coverage   88.38%   88.38%           
=======================================
  Files         176      176           
  Lines       12946    12946           
=======================================
  Hits        11442    11442           
  Misses       1504     1504

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

Sign in to view
@bbpbuildbot

This comment has been minimized.

Sign in to view
@JCGoran JCGoran marked this pull request as ready for review February 22, 2024 16:47
@JCGoran JCGoran requested review from 1uc, alkino and pramodk February 22, 2024 16:47
1uc
1uc reviewed Feb 22, 2024
View reviewed changes
Comment thread nmodl/ast.py
pramodk
pramodk approved these changes Feb 22, 2024
View reviewed changes

@pramodk pramodk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the example from README still works then this is all good!

@bbpbuildbot

This comment has been minimized.

Sign in to view
@JCGoran

JCGoran commented Feb 23, 2024

Copy link
Copy Markdown
Contributor Author

@pramodk I've added unit tests for the example from the README and caught a few issues along the way, should be okay now.

@JCGoran JCGoran requested review from 1uc and pramodk February 23, 2024 09:28
1uc
1uc reviewed Feb 23, 2024
View reviewed changes
Comment thread test/unit/pybind/data/exp2syn.json Outdated
1uc
1uc reviewed Feb 23, 2024
View reviewed changes
Comment thread nmodl/dsl.py
@JCGoran

JCGoran commented Feb 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Minor annoyance (similar to #1165): if we merge this, we need to update the Spack recipe with py-importlib-metadata and py-importlib-resources (only if we test on Python 3.8, if not, you can ignore this).

@codecov-commenter

codecov-commenter commented Feb 27, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.17%. Comparing base (1baa906) to head (8375255).

❗ Current head 8375255 differs from pull request most recent head 6ace4d8. Consider uploading reports for the commit 6ace4d8 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1166   +/-   ##
=======================================
  Coverage   87.17%   87.17%           
=======================================
  Files         175      175           
  Lines       12884    12884           
=======================================
  Hits        11232    11232           
  Misses       1652     1652

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

Sign in to view
@bbpbuildbot

This comment has been minimized.

Sign in to view
@bbpbuildbot

bbpbuildbot commented Feb 28, 2024

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #196575 (:white_check_mark:) have been uploaded here!

Status and direct links:

@JCGoran JCGoran merged commit cd4edec into master Feb 28, 2024
@JCGoran JCGoran deleted the jelic/remove_pkg_resources branch February 28, 2024 09:14
@JCGoran JCGoran mentioned this pull request Feb 28, 2024
Open
@JCGoran JCGoran mentioned this pull request Mar 6, 2024
Open
@JCGoran JCGoran mentioned this pull request Apr 7, 2024
Merged
ohm314 pushed a commit that referenced this pull request May 21, 2024
@JCGoran
Remove deprecated pkg_resources (#1166)
3ff1d01 
* Replace `pkg_resources` with `importlib`

* Update requirements

* Add test to make sure we can read examples from README
JCGoran added a commit to neuronsimulator/nrn that referenced this pull request Mar 12, 2025
@JCGoran
Remove deprecated pkg_resources (BlueBrain/nmodl#1166)
77b6648 
* Replace `pkg_resources` with `importlib`

* Update requirements

* Add test to make sure we can read examples from README

NMODL Repo SHA: BlueBrain/nmodl@cd4edec
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alkino alkino Awaiting requested review from alkino
@pramodk pramodk Awaiting requested review from pramodk
1 more reviewer
@1uc 1uc 1uc approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JCGoran @bbpbuildbot @codecov-commenter @pramodk @1uc