This repository was archived by the owner on Feb 26, 2025. It is now read-only.
Fix bug in build_neurodamus.sh script for neurodamus modules#1774
Merged
Conversation
pramodk
commented
Nov 24, 2022
- list of additional mod files are read from file and those contain trailing newline char
- comparison done between two list was returning undesired list of mod files due to leading newline char
* list of additional mod files are read from file and those
contain trailing newline char
* comparison done between two list was returning undesired
list of mod files due to leading newline char
Collaborator
|
Thank you for your pull request! Should you want to clear the PR build directory after failures, please use this pipeline. Before running the cleanup pipeline, please ensure that any PR building pipelines have been cancelled or finished running. |
Collaborator
|
To test your PR, use the following on BlueBrain5: unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/1774/config/modules.sh
module load unstable |
matz-e
approved these changes
Nov 25, 2022
pramodk
added a commit
that referenced
this pull request
Nov 28, 2022
* list of additional mod files are read from file and those
contain trailing newline char
* comparison done between two list was returning undesired
list of mod files due to leading newline char
heerener
pushed a commit
that referenced
this pull request
Jan 17, 2023
* list of additional mod files are read from file and those
contain trailing newline char
* comparison done between two list was returning undesired
list of mod files due to leading newline char
heerener
pushed a commit
that referenced
this pull request
Jan 23, 2023
* list of additional mod files are read from file and those
contain trailing newline char
* comparison done between two list was returning undesired
list of mod files due to leading newline char
heerener
pushed a commit
that referenced
this pull request
Jan 23, 2023
* list of additional mod files are read from file and those
contain trailing newline char
* comparison done between two list was returning undesired
list of mod files due to leading newline char
matz-e
pushed a commit
that referenced
this pull request
Jan 25, 2023
* list of additional mod files are read from file and those
contain trailing newline char
* comparison done between two list was returning undesired
list of mod files due to leading newline char
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.