Store all nodes for a specific symbol#934
Conversation
This way we can support the anti-feature of nrn having a function and a range variable having the same name
pramodk
left a comment
There was a problem hiding this comment.
overall looks fine! as discussed, adding unit test under visitor would be great!
|
Logfiles from GitLab pipeline #74978 (:no_entry:) have been uploaded here! Status and direct links: |
|
Logfiles from GitLab pipeline #75027 (:white_check_mark:) have been uploaded here! Status and direct links: |
|
Logfiles from GitLab pipeline #75240 (:white_check_mark:) have been uploaded here! Status and direct links: |
|
Logfiles from GitLab pipeline #75385 (:white_check_mark:) have been uploaded here! Status and direct links: |
Codecov Report
@@ Coverage Diff @@
## master #934 +/- ##
==========================================
+ Coverage 62.22% 62.32% +0.10%
==========================================
Files 194 194
Lines 28341 28402 +61
==========================================
+ Hits 17634 17701 +67
+ Misses 10707 10701 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ohm314
left a comment
There was a problem hiding this comment.
Generally looks good, but maybe a few minor details to fix.
pramodk
left a comment
There was a problem hiding this comment.
few minor nitpicks otherwise good to go! 🚀
pramodk
left a comment
There was a problem hiding this comment.
(should have approved it with the previous review)
|
Logfiles from GitLab pipeline #75492 (:white_check_mark:) have been uploaded here! Status and direct links: |
…/nmodl#934) * Until now only first AST node for a given symbol was stored in the AST * Because of this, it was not possible to find/lookup all nodes associated with a given symbol * This PR now changes the symbol implementation to store all encountered AST nodes. * Add tests for symbol class NMODL Repo SHA: BlueBrain/nmodl@68e7086
This way we can support the anti-feature of nrn having a function and a range variable having the same name