This repository was archived by the owner on Mar 25, 2025. It is now read-only.
Semantic analysis check for USEION variables in CONSTANT block#908
Merged
Conversation
Collaborator
|
Logfiles from GitLab pipeline #69939 (:white_check_mark:) have been uploaded here! Status and direct links: |
ohm314
approved these changes
Aug 18, 2022
ohm314
left a comment
Contributor
There was a problem hiding this comment.
really minor nitpicking otherwise looks good
Collaborator
|
Logfiles from GitLab pipeline #69996 (:white_check_mark:) have been uploaded here! Status and direct links: |
iomaganaris
approved these changes
Aug 22, 2022
iomaganaris
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Just a minor nitpick
6 tasks
* Similar to neuronsimulator/nrn#1955 * Add semantic analysis check to avoid declaring ion variables in CONSTANT {} block * Addresses first point in #888 MOD file is glia__dbbs_mod_collection__cdp5__CAM_GoC.mod. * Updated test
2d6ba1a to
5a546de
Compare
Co-authored-by: Omar Awile <omar.awile@epfl.ch>
5a546de to
fee9a3b
Compare
Collaborator
|
Logfiles from GitLab pipeline #73670 (:white_check_mark:) have been uploaded here! Status and direct links: |
Collaborator
|
Logfiles from GitLab pipeline #73669 (:white_check_mark:) have been uploaded here! Status and direct links: |
alkino
reviewed
Sep 9, 2022
Collaborator
|
Logfiles from GitLab pipeline #73702 (:white_check_mark:) have been uploaded here! Status and direct links: |
JCGoran
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Mar 12, 2025
…rain/nmodl#908) * Similar to #1955, add semantic analysis check to avoid declaring ion variables in CONSTANT {} block * Addresses first point in BlueBrain/nmodl#888 MOD file is glia__dbbs_mod_collection__cdp5__CAM_GoC.mod. * Updated test NMODL Repo SHA: BlueBrain/nmodl@af7c772
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in CONSTANT {} block
MOD file is glia__dbbs_mod_collection__cdp5__CAM_GoC.mod.