This repository was archived by the owner on Mar 25, 2025. It is now read-only.
Fix warnings and improve ccache performance.#723
Merged
Conversation
This makes them work properly in standalone builds, when NMODL is not a submodule of CoreNEURON.
Fixes NVHPC compiler warning: warning #612-D: overloaded virtual function "nmodl::ast::Ast::get_shared_ptr" is only partially overridden in class "PyAst".
Fixes compiler warning.
Otherwise clang-format-12 added whitespace that clang-format-11 did not.
This avoids #line directives and asserts containing the absolute path of the build directory, which should in turn improve ccache performance in the CI.
Collaborator
|
Logfiles from GitLab pipeline #14545 (:no_entry:) have been uploaded here! Status and direct links: |
Contributor
Author
|
I suspect the CI failure (in CVF) comes from the recent "psolve direct" merges to NEURON and CoreNEURON. We should fix that, but the content of this PR could be reviewed already. |
alexsavulescu
approved these changes
Aug 24, 2021
Collaborator
|
Logfiles from GitLab pipeline #14970 (:no_entry:) have been uploaded here! Status and direct links: |
Collaborator
|
Logfiles from GitLab pipeline #15041 (:white_check_mark:) have been uploaded here! Status and direct links: |
This was referenced Jan 4, 2022
JCGoran
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Mar 12, 2025
* Tweak NVHPC warning suppressions. This makes them work properly in standalone builds, when NMODL is not a submodule of CoreNEURON. * Add const version of PyAst::get_shared_ptr. Fixes NVHPC compiler warning: warning BlueBrain/nmodl#612-D: overloaded virtual function "nmodl::ast::Ast::get_shared_ptr" is only partially overridden in class "PyAst". * Remove unused variable. Fixes compiler warning. * Tweak code so clang-format-{11,12} agree. Otherwise clang-format-12 added whitespace that clang-format-11 did not. * Call flex and bison with relative paths. This avoids #line directives and asserts containing the absolute path of the build directory, which should in turn improve ccache performance in the CI. * Fix comment and add note about ccache misses. NMODL Repo SHA: BlueBrain/nmodl@e98f281
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a collection of minor fixes to compiler warnings (when compiling standalone).
It also changes how
flexandbisonare invoked so that relative paths are used.This should improve the
ccachehit rate on some files that the NVHPC compilers are extremely slow to compile.