This repository was archived by the owner on Mar 25, 2025. It is now read-only.
Avoid use of assert in the OpenACC kernel#720
Merged
Conversation
* Use of assert with atomic capture result into wrong results * See details in BlueBrain/mod2c#68
olupton
approved these changes
Aug 19, 2021
olupton
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, fixes the watchrange test locally...
Collaborator
|
Logfiles from GitLab pipeline #14316 (:white_check_mark:) have been uploaded here! Status and direct links: |
Collaborator
|
Logfiles from GitLab pipeline #14361 (:white_check_mark:) have been uploaded here! Status and direct links: |
Contributor
|
We reported a minimal reproducer of this problem (or of a similar problem, anyway) in https://forums.developer.nvidia.com/t/incorrect-gpu-results-with-pragma-acc-atomic-capture/187962. |
5 tasks
JCGoran
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Mar 12, 2025
* Use of assert with atomic capture result into wrong results * See details in BlueBrain/mod2c#68 NMODL Repo SHA: BlueBrain/nmodl@cf56a24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
into wrong results