Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

fix bad translation of netmove(expr)#714

Merged
ohm314 merged 1 commit into
masterfrom
hines/netmove-extra-t
Aug 9, 2021
Merged

fix bad translation of netmove(expr)#714
ohm314 merged 1 commit into
masterfrom
hines/netmove-extra-t

Conversation

@nrnhines

@nrnhines nrnhines commented Aug 7, 2021

Copy link
Copy Markdown
Collaborator

Without this change the nmodl translation of

                        net_move(t + dur)

was

                        net_send_buffering(ml->_net_send_buffer, 2, inst->tqitem[2*pnodecount+id], -1, inst->point_process[1*pnodecount+id], t+t + inst->dur[id], 0.0);

@nrnhines nrnhines requested a review from alexsavulescu August 7, 2021 03:10
@bbpbuildbot

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #12919 (:white_check_mark:) have been uploaded here!

Status and direct links:

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #714 (17cd3b9) into master (d7b82bb) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #714   +/-   ##
=======================================
  Coverage   60.47%   60.47%           
=======================================
  Files         200      200           
  Lines       33283    33283           
=======================================
  Hits        20128    20128           
  Misses      13155    13155           
Impacted Files Coverage Δ
src/codegen/codegen_c_visitor.cpp 63.89% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7b82bb...17cd3b9. Read the comment docs.

@ohm314 ohm314 merged commit d38bb5a into master Aug 9, 2021
@ohm314 ohm314 deleted the hines/netmove-extra-t branch August 9, 2021 05:24
olupton added a commit to BlueBrain/CoreNeuron that referenced this pull request Aug 9, 2021
@olupton olupton mentioned this pull request Aug 9, 2021
1 task
JCGoran pushed a commit to neuronsimulator/nrn that referenced this pull request Mar 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants